ASM Scaling UI #7455
ASM Scaling UI #7455
Conversation
| @@ -49,6 +49,7 @@ public WorkspaceInfo() | |||
| double cx = 0; | |||
| double cy = 0; | |||
| double zoom = 1.0; | |||
| double scaleFactor = 1.0; | |||
There was a problem hiding this comment.
@ramramps @QilongTang @sm6srw seems we may need to serialize this?
There was a problem hiding this comment.
In any case, this gets stored in DYN and Flood needs this?
There was a problem hiding this comment.
We have zoom property serialized to workspace db, currently I believe we have no case utilizing the scaleFactor, but if we want to have this ASM scaling in Flood editor then we will probably need this
There was a problem hiding this comment.
there is a UI associated with this which webUI might need - in addition I am not sure if we need to scale the tessellated geometry after it is returned from ASM or if LibG is doing this scaling of the tessellated geometry @aparajit-pratap can you fill us in here?
There was a problem hiding this comment.
@mjkkirschner yes, the scale factor needs to be serialized to the DYN file. This PR takes care of that for desktop. Yes, you would need to introduce the same in Flood as well as the new UI. The tessellated geometry is scaled back after it is returned from ASM and this is taken care of in LibG. Let me know if you have further questions.
There was a problem hiding this comment.
thanks @aparajit-pratap - good to know, first question that comes to mind which is not obvious to me from this code is where does the scalefactor get injected into LibG?
Purpose
This is a merge of #6991 with the addition of some minor fixes to force re-execute the graph only when the geometry scale setting is changed and not every time the dialog is opened.
Closing #6991 ...
Declarations
Check these if you believe they are true
*.resxfiles