-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remember position of Python editor windows & fix crash when deleting a Python node with an open editor #8295
Conversation
…r the option to cancel
Thanks for doing this @Dewb. Just linked it to the OP about resizing Python windows. When this is merged, we should close that issue. Also, would you mind adding images of the UI changes to the description? We typically do this for all UI changes per the declaration checklist. |
@Dewb LGTM! |
@Racel image added! |
Hey @Dewb I'm just curious what happens when you close a python node on an external monitor, and then later reopen it when the monitor doesn't exist? |
@mjkkirschner I finally got some "free time" (ha!) today to investigate your very good question, and as I expected, the window is restored offscreen in that situation. Just pushed a fix. It's been tested on my 3-display desktop, but it could use some additional testing on a high-DPI display. (Updated the description with this feature.) |
@Dewb I will try to test this this weekend. |
@mjkkirschner - is this good to merge? |
@Racel LGTM |
Purpose
Python editor windows that are moved or resized from the initial location will remember their new size/position for the duration of the Dynamo session. This size information will not be persisted to the workspace, so closing and reopening the workspace, or Dynamo, will reset the window locations back to their default position.
If an editor window is on a secondary display when it is closed, and the secondary display is disconnected, the editor window will be restored to the default position if it is opened.
This also fixes a crash issue when the user deletes a Python node while the editor window is still open. The user will be shown a warning dialog giving them the opportunity to cancel the deletion, or hit OK to close the window and delete the node. (QNTM-2533).
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@aparajit-pratap
FYIs
@Racel