Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 9483 - Minor Bug: Auto missing from the lacing menu when multiple nodes are selected #9572

Merged
merged 3 commits into from
Apr 1, 2019

Conversation

RyaPorter
Copy link
Contributor

Purpose

Fixes issue #9483.
The option was just missing from the context menu altogether, not just when selecting multiple nodes as the issue describes. The option has now been added.

DynamoUIChange

DynamoUIChangeMultiple

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

@mjkkirschner
Copy link
Member

@RyaPorter thanks!

@alfarok
Copy link
Contributor

alfarok commented Apr 1, 2019

@QilongTang @mjkkirschner This should be good to go. I pulled it down locally for testing and we added some new tests covering lacing commands and verifying all appropriate options are present in the UI. All tests are also passing on the self-serve CI. Thanks @RyaPorter for tracking down the original issue and submitting the fix. I am merging into master and passing the task over to our QA @smangarole for final testing.

@alfarok alfarok merged commit 92cad94 into DynamoDS:master Apr 1, 2019
@RyaPorter RyaPorter deleted the ContextMenuAutoLacing branch April 8, 2019 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants