Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamo Text is not compatible with Mono #4

Open
ikeough opened this issue Apr 26, 2016 · 7 comments
Open

Dynamo Text is not compatible with Mono #4

ikeough opened this issue Apr 26, 2016 · 7 comments

Comments

@ikeough
Copy link

ikeough commented Apr 26, 2016

DynamoText requires PresentationCore. We should find a way to make a mono-compatible text rendering library which can still deal with multiple fonts.

@kronz
Copy link

kronz commented Apr 26, 2016

@ikeough: design aside, is there any reason technically not to make DynamoText nodes part of the regular github repo (out of the box functionality)?

@ikeough
Copy link
Author

ikeough commented Apr 26, 2016

@kronz Yes. Because the "regular" repo should not contain any node libraries. All node libraries should have their own repositories, tests etc. They should be distributed as packages. See DynamoDS/PackageManagerClient#13.

@kronz
Copy link

kronz commented Apr 26, 2016

@ikeough ok my polemical friend, let me restate: any reason that Dynamo text functionality can't live with the same nodes that are currently in https://github.com/DynamoDS/Dynamo/tree/master/src/Libraries/CoreNodes

@kronz
Copy link

kronz commented Apr 26, 2016

@ikeough after thinking about it, I can answer that myself. Dynamo text is not appropriate there either, as it's a weird mash up of String and Geometry,

@ikeough
Copy link
Author

ikeough commented Apr 26, 2016

@kronz Are you asking where it should live in the library, or where the code should live?

My statement above wasn't just to be argumentative. It's the right thing to do for Dynamo's growing collection of libraries. We can't just continue sticking code in "core nodes" because "core" loses its meaning. Also, as this issue points out, the DynamoText nodes could not go in core nodes currently because they're not mono-compatible.

@kronz
Copy link

kronz commented Apr 26, 2016

@ikeough I'm working backwards from the browser to try and understand what makes sense in terms of code, athough that might be beside the point for my purposes. Originally, I was trying to understand where we would put it to have it available "out of the box" for Dynamo Core functionality, as it seems like a basic thing to be able to instantiate text. But after thinking about it, the reliance on Geometry makes it a little weirder, so how to make it available for Dynamo Studio and Dynamo for Revit, or anything that has a geometry library. I'm gravitating to actually saying we should have the functionality available as a feature of the Geometry library and treat it as a shape, seperate from the ability to "label" elements with light weight and purely graphical elements.

@mjkkirschner
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants