i#1312 AVX-512 support: Add code cache enter/return context switching. #3738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 17, 2019 14:22
Adds support for dynamic AVX-512 context switching to/from the code cache. DynamoRIO now saves and restores the AVX-512 context once AVX-512 has been detected in the application. The latter is called lazy context switching in DynamoRIO. Mask registers are saved with respect to their width dependent on the AVX-512BW feature support of the processor. Adds the internal function proc_set_num_simd_saved() used to change the number of saved SIMD registers that is also returned by proc_num_simd_saved(). Adds the internal function move_mm_avx512_reg_opcode() that is intentionally distinct from move_mm_reg_opcode(), because its uses are distinct as well. Renames FEATURE_AVX512 to FEATURE_AVX512F and adds FEATURE_AVX512BW. In the same context, renames OPMASK_REG_SIZE to OPMASK_AVX512BW_REG_SIZE and adds OPMASK_AVX512F_REG_SIZE. Both changes reflect the different mask register width dependent on the AVX-512BW processor feature. DynamoRIO reserves enough space by default for the wider variant, but different kmov[wq] instructions are used to read and write mask registers. For x86, saving SIMD registers during a code-cache context switch has been moved after saving the flags, because saving SIMD now adds control flow. The same applies to restoring the SIMD registers, respectively. Adds a per-thread LOG entry when AVX-512 detection occurs. Adds an AVX-512 test for above. The test also works in 32-bit mode. Issue: #1312
hgreving2304
commented
Jul 17, 2019
hgreving2304
commented
Jul 18, 2019
hgreving2304
changed the title
added 14 commits
July 18, 2019 08:14
Offset changed to multiplication.
Uses atomic writes for d_r_set_avx512_code_in_use() and proc_set_num_simd_saved(). Unprotects .data before calling d_r_set_avx512_code_in_use() and proc_set_num_simd_saved().
… able to save 64-bit masks.
hgreving2304
commented
Jul 18, 2019
added 2 commits
July 19, 2019 06:40
Comment, flags reordered.
|
PTAL. |
derekbruening
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for dynamic AVX-512 context switching to/from the code cache. DynamoRIO now
saves and restores the AVX-512 context once AVX-512 has been detected in the application.
The latter is called lazy context switching in DynamoRIO. Mask registers are saved with
respect to their width dependent on the AVX-512BW feature support of the processor.
Adds the internal function proc_set_num_simd_saved() used to change the number of saved
SIMD registers that is also returned by proc_num_simd_saved().
Adds the internal function move_mm_avx512_reg_opcode() that is intentionally distinct from
move_mm_reg_opcode(), because its uses are distinct as well.
Renames FEATURE_AVX512 to FEATURE_AVX512F and adds FEATURE_AVX512BW. In the same
context, renames OPMASK_REG_SIZE to OPMASK_AVX512BW_REG_SIZE and adds
OPMASK_AVX512F_REG_SIZE. Both changes reflect the different mask register width dependent
on the AVX-512BW processor feature. DynamoRIO reserves enough space by default for the
wider variant, but different kmov[wq] instructions are used to read and write mask
registers.
For x86, saving SIMD registers during a code-cache context switch has been moved after
saving the flags, because saving SIMD now adds control flow. The same applies to restoring
the SIMD registers, respectively.
Moves the global variable d_r_avx512_code_in_use to reachable heap.
Adds an ATOMIC_1BYTE_WRITE() macro.
Adds a per-thread LOG entry when AVX-512 detection occurs.
Adds an AVX-512 test for above. The test also works in 32-bit mode.
Issue: #1312