i#2502 lockless ARM: Fix missing AArch synchronization #4269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For update_lookuptable_tls: Adds a store-release to the lookuptable store and a load-acquire to the IBL generated code for both ARM and AArch64, as there is no lighter-weight way to ensure the mask and table stores are seen in the proper order. For flushtime_global: made all readers and the increment use store-release semantics. For safely_nullify_tables: leaving as weak stores since timing and ordering does not matter there. Issue: #2502
|
@algr , @AssadHashmi -- hoping for a review from someone from ARM. |
algrant-arm
reviewed
Apr 21, 2020
algrant-arm
reviewed
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For update_lookuptable_tls: Adds a store-release to the lookuptable
store and a load-acquire to the IBL generated code for both ARM and
AArch64, as there is no lighter-weight way to ensure the mask and
table stores are seen in the proper order.
For flushtime_global: made all readers and the increment use
store-release semantics.
For safely_nullify_tables: leaving as weak stores since timing and
ordering does not matter there.
Issue: #2502