Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#2502 locks: Fix bug in ATOMIC_MAX on AArchXX #5367

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

derekbruening
Copy link
Contributor

Adds a missing load-acquire in a loop in ATOMIC_MAX that causes hangs
in RSTATS_ADD_PEAK.

Tested on the client.annotation-concurrency test on AArch64 where
without this fix it hangs under release-build plain DR every ~100
runs. With the fix, there is no hang in 20K runs.

Issue: #2502, #4928

Adds a missing load-acquire in a loop in ATOMIC_MAX that causes hangs
in RSTATS_ADD_PEAK.

Tested on the client.annotation-concurrency test on AArch64 where
without this fix it hangs under release-build plain DR every ~100
runs.  With the fix, there is no hang in 20K runs.

Issue: #2502, #4928
@derekbruening
Copy link
Contributor Author

I am highly confident that this fixes #5366. Without this fix I saw hangs in dr$sim -offline every ~100-300 runs; with the fix, no hangs in 20K runs. That is similar to the plain DR rates. dr$sim online however also has a different, more frequent hang that #4928 covers: have not figured that one out yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants