i#4393 New AArch64 codec implementation #5453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is an example of the code which will be generated from a machine readable specification (MRS) to decode and encode AArch64 instructions from v8.1 onwards. It is provided for review and discussion purposes, in order to resolve any issues which may arise and to make visible what changes to expect. This patch does not include the MRS, the parser or generator, just an example of the target code which we intend to generate, based on the v8.1 SQRDMLAH instruction. Issue: #4393, #3044, #2626
AssadHashmi
requested review from
derekbruening,
abhinav92003 and
joshua-warburton
|
It seems reasonable at a glance. I'm not sure exactly how to evaluate: nothing jumps out as problematic. If we'll get auto-generation of INSTR_CREATE_ macros and easier splitting of opcodes it sounds good to me. |
joshua-warburton
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is an example of the code which will be generated from a
machine readable specification (MRS) to decode and encode AArch64
instructions from v8.1 onwards.
It is provided for review and discussion purposes, in order to resolve
any issues which may arise and to make visible what changes to expect.
This patch does not include the MRS, the parser or generator, just an
example of the target code which we intend to generate, based on the
v8.1 SQRDMLAH instruction.
Issue: #4393, #3044, #2626