i#2039 trace trim, part 5: Drop early data #5768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part 4 added a minimum timestamp, but it only works for data that is not actually emitted until we are fully attached. For data emitted before that point, we'll use a too-early timestamp. We solve that here by dropping such data. Tested on a large app where these changes solve gaps at the start of the trace due to an early timestamp in one thread. Issue: #2039
|
Update: it turns out this is not needed on the big app in question; there was some other error in prior results. But this is still a theoretical issue. It is not easy to make an automated test unfortunately. |
abhinav92003
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 4 added a minimum timestamp, but it only works for data that is not actually emitted until we are fully attached. For data emitted before that point, we'll use a too-early timestamp. We solve that here by dropping such data.
Tested on a large app where these changes solve gaps at the start of the trace due to an early timestamp in one thread.
Issue: #2039