i#2039 trace trim, part 6: Enable for AArchXX #5770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the stability issues with drbbdup on larger apps seem limited to x86, we enable -align_endpoints by default for AArchXX. Issue: #2039
1) OP_isb must end a bb. Added this to drbbdup's list of special opcodes, and to the bb event docs where it was missing. This fixes drcacheoff.gencode test failures. 2) Add more synch to the burst_replaceall test to ensure all threads are scheduled to avoid empty threads which mess up the expected output with -align_endpoints. 3) Relax the burst_threadfilter template to allow empty unscheduled threads. 4) Relax the burst_replace template to allow lazy file opening.
|
x32 failure is scattergather pipe assert #5329 |
abhinav92003
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the stability issues with drbbdup on larger apps seem limited to x86, we enable -align_endpoints by default for AArchXX.
Issue: #2039