-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i#3544 riscv64: Enable dynamorio unit test compile #5929
Conversation
Make unit tests compile by disabling them all. Next enable one test at a time when it pass. Notice: There are still a large number of unimplemented in Dynamorio RISC-V 64, and it cannot be tested via QEMU Issue #3544
@derekbruening |
SVE gather load/stores were inadvertently using the `DR_EXTEND_UXTB` extend type rather than `DR_EXTEND_UXTX`. Issue #3044
All done. |
I updated this PR to the latest master branch, and then I found that the CI could not pass. So I revert the updated commit, this is the reason why my PR has some modifications of the aarch64 decoder. @derekbruening |
Please add comments/labels explaining that in the future as otherwise it looks like an unintentional mistake when looking just at the diff. |
Thank you for your advice and help. I will pay attention next time. |
Looks good, except it looks like you've missed one comment about the too-long line: once that's fixed we can merge it in. |
I don't know if the too-long line you said that is:
|
Sorry for replying too late. These changes are all done. @derekbruening |
Make unit tests compile by disabling them all.
Next, enable one test at a time when it passes.
Add RISCV-V 64 support to suite/tests/linux/infinite.c, and clients/drcachesim/tests/raw2trace_unit_tests.cpp
Notice: There are still a large number of unimplemented in Dynamorio RISC-V 64, and it cannot be tested via QEMU
Issue #3544