Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table creation #283

Merged
merged 4 commits into from
Aug 5, 2018
Merged

Fix table creation #283

merged 4 commits into from
Aug 5, 2018

Conversation

andrykonchin
Copy link
Member

@andrykonchin andrykonchin commented Aug 4, 2018

Changes:

  • Fix issue with using :date/:datetime as a partition/sort key and storing with string format
  • Fix handling field type of custom type specified with dynamoid_field_type - it was used as native DynamoDb attribute type but should be treated as Dynamoid field type
  • Use new proper exception Dynamoid::Errors::UnsupportedKeyType

The main issue: :date and :datetime fields can be stored in string format but when table is created Number type is used unconditionally.

@coveralls
Copy link

coveralls commented Aug 4, 2018

Coverage Status

Coverage increased (+0.1%) to 98.564% when pulling 9b23ae7 on fix-table-creation into 2744fa5 on master.

Copy link
Member

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pboling pboling merged commit 99cd84b into master Aug 5, 2018
@pboling pboling deleted the fix-table-creation branch August 5, 2018 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants