remove code sample that not exist as specifications in update method. #721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
※ related to #720 that closed it due to my ineptitude.
Hello, thank you for maintenance of this gem.
Probably related to issue #657.
I found what incorrect code sample of update method in readme.md.
.update method does not accept conditions as arguments.
dynamoid/lib/dynamoid/persistence.rb
Line 232 in 6b96d1d
def update(hash_key, range_key_value = nil, attrs)
Therefore, the following code as shown in the sample will fail.
Address.update(id, { city: 'Chicago' }, if: { deliverable: true })
So I removed this code sample.
thank you!