Ready for stable release (in theory) #134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR was to make it ready for stable release for that I:
Lower FSharp.Core requirements -> related to the discussion in Update Fable.Core and FSharp.Core #126
Clean up dependencies -> You should only need to depends on
Feliz
notFeliz.CompilerPlugins
.Feliz.CompilerPlugins
should be controlled byFeliz
I also updated the docs project to use Webpack 5, because this is requirred in order to use Fable.Elmish.HMR latest version. And the project is also updated to Elmish 4.
My only problem is that I can't make the icons work using only the SCSS import. To hack around that I included a CDN version of it via the
index.html
file. I don't know if this is related to a change I made or if it was broken before.