Hommexx: fixing cmake cache files #6455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merges updated master from E3SM with my local changes for weaver
… up some unneeded args
oksanaguba
reviewed
May 31, 2024
| MESSAGE(STATUS " Linking Fortran with -cxxlib") | ||
| TARGET_LINK_LIBRARIES(${execName} -cxxlib) | ||
| ENDIF () | ||
| # IF (CXXLIB_SUPPORTED_CACHE) |
There was a problem hiding this comment.
Skyler will figure out why this is an issue on weaver, if not anything else, there will be an if statement 'if not WEAVER'...
rljacob
added
HOMME standalone
added 6 commits
May 31, 2024 11:30
… both compile. bfb testing needed oksanas change for kokkos gpu update
oksanaguba
reviewed
Jun 16, 2024
| MESSAGE(STATUS " Linking Fortran with -cxxlib") | ||
| TARGET_LINK_LIBRARIES(${execName} -cxxlib) | ||
| ENDIF () | ||
| #IF (CXXLIB_SUPPORTED_CACHE) |
There was a problem hiding this comment.
could you please uncomment these 2 blocks back?
oksanaguba
reviewed
Jun 16, 2024
| ELSE() | ||
| SET(CXXLIB_SUPPORTED_CACHE FALSE CACHE BOOL "") | ||
| ENDIF () | ||
| #CHECK_CXX_COMPILER_FLAG("-cxxlib" CXXLIB_SUPPORTED) |
oksanaguba
reviewed
Jun 16, 2024
| #SET (NetCDF_Fortran_PATH "${NFCONFIG_OUTPUT}" CACHE STRING "") | ||
|
|
||
| # Set the path manually otherwise /home/projects/e3sm/scream/libs/netcdf-fortran/install/weaver will get grabbed | ||
| SET (NetCDF_Fortran_PATH /projects/ppc64le-pwr9-rhel8/tpls/netcdf-fortran/4.6.0/gcc/11.3.0/openmpi/4.1.4/5ka6asw CACHE FILEPATH "") |
There was a problem hiding this comment.
would you remind me why this path was hardcoded? it seems nc-config works, but nf-config does not?
oksanaguba
reviewed
Jun 16, 2024
|
|
||
| # TPL settings | ||
| #SET (PnetCDF_PATH /projects/ppc64le-pwr9-rhel8/tpls/parallel-netcdf/1.12.3/gcc/11.3.0/openmpi/4.1.4/pp6jcjk CACHE FILEPATH "") | ||
| SET (CPRNC_DIR /projects/e3sm/cprnc CACHE FILEPATH "") |
There was a problem hiding this comment.
let's remove this cprnc, we now know it does not work. same is about the other weaver file.
|
@oksanaguba please re-review. |
skyler-ruiter
changed the title
oksanaguba
changed the title
|
Notes: needs one more review from @oksanaguba |
rljacob
changed the title
|
@oksanaguba please approve. |
|
closing this till i can get back to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets weaver cache file working again, compiles with kokkos and parallel-IO.
Also cleans up cache file by removing some unneeded arguments and adding comments.