Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change hi-res tests to use the v3 grid configurations #6479

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Change hi-res tests to use the v3 grid configurations #6479

merged 3 commits into from
Jun 27, 2024

Conversation

jonbob
Copy link
Contributor

@jonbob jonbob commented Jun 18, 2024

The current high-resolutions tests use older grid configurations. This updates the tests to use the new RRSwISC6to18E3r5 mesh as well as r025 for trigrid tests.

[BFB]

@jonbob jonbob added BFB PR leaves answers BFB HighRes Testing Anything related to unit/system tests labels Jun 18, 2024
@jonbob jonbob requested a review from rljacob June 18, 2024 23:01
@jonbob jonbob self-assigned this Jun 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6479/
on branch gh-pages at 2024-06-21 22:44 UTC

@jonbob
Copy link
Contributor Author

jonbob commented Jun 18, 2024

@rljacob -- I didn't test this yet. It looks like the e3sm_hi_res suite runs on pm-cpu, so I can try that

@rljacob rljacob requested a review from amametjanov June 19, 2024 02:17
@jonbob
Copy link
Contributor Author

jonbob commented Jun 19, 2024

A quick test running:

./create_test e3sm_hi_res

successfully built and submitted two of the tests. The third,

SMS.ne120pg2_r025_RRSwISC6to18E3r5.WCYCL1950.pm-cpu_intel.eam-cosplite

failed in setup due to:

       ERROR : CLM build-namelist::ELMBuildNamelist::add_default() : No default value found for fsurdat.

@ndkeen
Copy link
Contributor

ndkeen commented Jun 19, 2024

I tried SMS.ne120pg2_r025_RRSwISC6to18E3r5.WCYCL1850.pm-cpu_intel.eam-cosplite (ie using 1850 instead) and it does build. But looks like missing some files that are not on blues.

        Model elm no file specified for finidat
        svn export failed with output:  and errput svn: E170000: URL 'https://svn-ccsm-inputdata.cgd.ucar.edu/trunk/inputdata/cpl/gridmaps/ne120pg2/map_r025_to_ne120pg2_traave.20240328.nc' doesn't exist
        
        svn export failed with output:  and errput svn: E170000: URL 'https://svn-ccsm-inputdata.cgd.ucar.edu/trunk/inputdata/cpl/gridmaps/ne120pg2/map_r025_to_ne120pg2_trbilin.20240328.nc' doesn't exist
        
        svn export failed with output:  and errput svn: E170000: URL 'https://svn-ccsm-inputdata.cgd.ucar.edu/trunk/inputdata/share/domains/domain.lnd.r025_RRSwISC6to18E3r5.240328.nc' doesn't exist

@jonbob
Copy link
Contributor Author

jonbob commented Jun 19, 2024

Thanks @ndkeen -- let me track down those files

@rljacob
Copy link
Member

rljacob commented Jun 19, 2024

Go ahead and switch that test to 1850 .

@jonbob
Copy link
Contributor Author

jonbob commented Jun 19, 2024

@ndkeen -- is that from master? I don't see those files in config_grids

@ndkeen
Copy link
Contributor

ndkeen commented Jun 19, 2024

Ah, no that was with xuezhengllnl/v3hrcoupledtest

@jonbob
Copy link
Contributor Author

jonbob commented Jun 19, 2024

Changed the fully-coupled test to 1850, verified that it sets up and builds on pm-cpu

@jonbob
Copy link
Contributor Author

jonbob commented Jun 20, 2024

Two of the three tests ran successfully on pm-cpu but this one:

SMS.ne120pg2_r025_RRSwISC6to18E3r5.WCYCL1850.pm-cpu_intel.eam-cosplite

fails because we don't have default spunup ocn/ice ICs. We can either add a default set of IC files temporarily or try testing with WCYCL1850NS

@rljacob
Copy link
Member

rljacob commented Jun 20, 2024

Using 1850NS would be ok.

@jonbob
Copy link
Contributor Author

jonbob commented Jun 20, 2024

OK, I've submitted a test of:

SMS.ne120pg2_r025_RRSwISC6to18E3r5.WCYCL1850NS.pm-cpu_intel.eam-cosplite

If it runs successfully, I'll change the test in this PR to match

@jonbob
Copy link
Contributor Author

jonbob commented Jun 21, 2024

The most recent test,

SMS.ne120pg2_r025_RRSwISC6to18E3r5.WCYCL1850NS.pm-cpu_intel.eam-cosplite

ran OK but timed out after three days. Trying now with SMS_Ld3

@jonbob
Copy link
Contributor Author

jonbob commented Jun 21, 2024

Passes:
SMS_Ld3.ne120pg2_r025_RRSwISC6to18E3r5.WCYCL1850NS.pm-cpu_intel.eam-cosplite

Modified test to run for three days

jonbob added a commit that referenced this pull request Jun 26, 2024
@jonbob
Merge branch 'jonbob/testing/make-hr-tests-v3' into next (PR #6479)
3b2086e 
Change hi-res tests to use the v3 grid configurations

The current high-resolutions tests use older grid configurations. This
updates the tests to use the new RRSwISC6to18E3r5 mesh as well as r025
for trigrid tests.

[BFB]
@jonbob
Copy link
Contributor Author

jonbob commented Jun 26, 2024

merged to next

@jonbob jonbob merged commit 7be5f66 into master Jun 27, 2024
21 checks passed
@jonbob jonbob deleted the jonbob/testing/make-hr-tests-v3 branch June 27, 2024 16:26
@jonbob
Copy link
Contributor Author

jonbob commented Jun 27, 2024

merged to master

@jonbob jonbob mentioned this pull request Jul 8, 2024
Merged
jonbob added a commit that referenced this pull request Jul 15, 2024
@jonbob
Merge branch 'jonbob/testing/fix-hr-test' into next (PR #6504)
2354d2f 
Change fully-coupled HR test to WCYCL1850NS

This was intended to be part of PR #6479 but I missed that commit. It
changes the current fully-active high-res test from WCYCL1850 to
WCYCL1850NS because the ocn and ice do not have spunup initial
conditions defined yet for the RRSwISC6to18E3r5 mesh.

[BFB] for all tested configurations
jonbob added a commit that referenced this pull request Jul 16, 2024
@jonbob
Merge branch 'jonbob/testing/fix-hr-test' (PR #6504)
9986482 
Change fully-coupled HR test to WCYCL1850NS

This was intended to be part of PR #6479 but I missed that commit. It
changes the current fully-active high-res test from WCYCL1850 to
WCYCL1850NS because the ocn and ice do not have spunup initial
conditions defined yet for the RRSwISC6to18E3r5 mesh.

[BFB] for all tested configurations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amametjanov amametjanov amametjanov approved these changes

@rljacob rljacob Awaiting requested review from rljacob

Assignees

@jonbob jonbob

Labels
BFB PR leaves answers BFB HighRes Testing Anything related to unit/system tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonbob @ndkeen @rljacob @amametjanov