Skip to content
This repository has been archived by the owner on Apr 28, 2023. It is now read-only.

implemented rebrandable OLS with environment variables for #438 #482

Merged
merged 6 commits into from
Nov 9, 2021

Conversation

giraygi
Copy link
Contributor

@giraygi giraygi commented May 27, 2021

Current debranding feature disables the use of some functionalities. For this reason, I have introduced a new variable to be able to hide some EBI specific content. Plus, I have introduced several branding variables for adapting some page content to the identity of another institution willing to maintain the service. These variables can be assigned to the docker-compose file as environment variables.

@matentzn
Copy link
Contributor

Super cool @giraygi, do you have a public instance somewhere where I can see how your changes look like life? I am not directly on the OLS team, but interested in your changes for some of our custom OLS projects.

@giraygi
Copy link
Contributor Author

giraygi commented Jun 1, 2021

Super cool @giraygi, do you have a public instance somewhere where I can see how your changes look like life? I am not directly on the OLS team, but interested in your changes for some of our custom OLS projects.

Thanks a lot @matentzn . We have two public instances to give you an idea about my changes. They are: TS of NFDI4Ing and TS of TIB Central. The footer is not very fancy yet since I wanted to stick to the code of EBI OLS as much as possible but I will update it soon once my changes are approved. Plus, this rebranding currently excludes favicons. I will also add it later.

@matentzn
Copy link
Contributor

matentzn commented Jun 1, 2021

This is really amazing! :) Nice job!

@jamesamcl
Copy link
Member

This is great, thank you! I will get it merged this week. 😃

@giraygi
Copy link
Contributor Author

giraygi commented Jun 1, 2021

Thanks a lot guys! I am very glad that I might be of any help :)

@giraygi
Copy link
Contributor Author

giraygi commented Aug 11, 2021

@udp Hello again. I wanted to remind you that I had made a few corrections (4 more commits on 2nd of June ) after you confirmed my pull request.

@jamesamcl jamesamcl merged commit 8f45946 into EBISPOT:main Nov 9, 2021
@jamesamcl
Copy link
Member

Thanks!

@giraygi
Copy link
Contributor Author

giraygi commented Nov 15, 2021

Thanks!

No Problem! I have a small bug-fix and documentation added for this in #516

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants