Identifierv2 #118
Identifierv2 #118
Conversation
| @Autowired | ||
| private VariantWithSamplesAndAnnotationsService service; | ||
|
|
||
| @GetMapping(value = "/{identifierId}") |
There was a problem hiding this comment.
I would leave this as "identifier". Id is a shorthand of identifier anyway
| new ParameterizedTypeReference<List<Variant>>() { | ||
| }); | ||
| assertEquals(HttpStatus.OK, response.getStatusCode()); | ||
| assertTrue(response.getBody().size() > 0); |
There was a problem hiding this comment.
checking at least the important fields like chromosome and position and alleles would be nice. just in case we are returning an object will all fields as null.
Applies to the other test class too.
| new ParameterizedTypeReference<List<Variant>>() { | ||
| }); | ||
| assertEquals(HttpStatus.OK, response.getStatusCode()); | ||
| assertEquals("20", response.getBody().get(0).getChromosome()); |
There was a problem hiding this comment.
Maybe you could assign response.getBody().get(0) to a variable, to make the next statements more meaningful.
eva-server/src/test/java/uk/ac/ebi/eva/server/ws/IdentifierWSServerV2IntegrationTest.java
Outdated
Show resolved
Hide resolved
eva-server/src/test/java/uk/ac/ebi/eva/server/ws/IdentifierWSServerV2Test.java
Show resolved
Hide resolved
eva-server/src/test/java/uk/ac/ebi/eva/server/ws/IdentifierWSServerV2Test.java
Show resolved
Hide resolved
Co-Authored-By: Cristina Yenyxe Gonzalez Garcia <cyenyxe@ebi.ac.uk>
|
I tried deploying this locally, and it looks fine. My only comment would be to improve the description of the parameters, like adding an example, explaining that the species and assembly can be looked up in |
| assertEquals("A", variantList.get(0).getReference()); | ||
| assertEquals(60100L, variantList.get(0).getStart()); | ||
| assertEquals(60100L, variantList.get(0).getEnd()); | ||
| assertTrue(variantList.size() > 0); |
There was a problem hiding this comment.
This assert should be executed before trying to access the first element in the list.
| assertEquals("1", variantList.get(0).getChromosome()); | ||
| assertEquals("T", variantList.get(0).getAlternate()); | ||
| assertEquals("A", variantList.get(0).getReference()); | ||
| assertTrue(variantList.size() > 0); |
There was a problem hiding this comment.
This assert should be executed before trying to access the first element in the list.
| public ResponseEntity getVariants( | ||
| @ApiParam(value = "RS or SS identifier of a variant, e.g.: rs55880202", required = true) @PathVariable | ||
| String identifier, | ||
| @ApiParam(value = "Allowed values can be looked up in /v1/meta/species/list/ in the field named " |
There was a problem hiding this comment.
First letter of the genus, followed by the full species name, e.g. hsapiens. Allowed values can be looked up in /v1/meta/species/list/ in the field named 'taxonomyCode'.
| String identifier, | ||
| @ApiParam(value = "Allowed values can be looked up in /v1/meta/species/list/ in the field named " | ||
| + "taxonomyCode, e.g.: hsapiens", required = true) @RequestParam String species, | ||
| @ApiParam(value = "Allowed values can be looked up in /v1/meta/species/list/ in the field named " |
There was a problem hiding this comment.
Encoded assembly name, e.g. grch37. Allowed values can be looked up in /v1/meta/species/list/ in the field named 'assemblyCode'.
No description provided.