BugFixes #129
Merged
BugFixes #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmmut
reviewed
Aug 22, 2019
| private void checkParameters(String species, String assembly, Integer bufferValue) throws IllegalArgumentException { | ||
| private void checkParameters(List<String> geneIds, String species, String assembly, Integer bufferValue) | ||
| throws IllegalArgumentException { | ||
| long emptyGeneIdCount = geneIds.stream().map(String::isEmpty).filter(value -> value == true).count(); |
There was a problem hiding this comment.
what this is checking is if any element is an empty string. I didn't think about this but it would be nice to search only non-empty strings, but my comment was that the endpoint allows to search by an empty list, which this method will allow right now.
so use this line to filter out empty elements, and fail only if the resulting list is empty.
jmmut
requested changes
Aug 22, 2019
jmmut
approved these changes
Aug 22, 2019
andresfsilva
requested changes
Aug 22, 2019
eva-server/src/main/java/uk/ac/ebi/eva/server/ws/GeneWSServerV2.java
Outdated
Show resolved
Hide resolved
…2.java Co-Authored-By: andresfsilva <afsilva04@gmail.com>
andresfsilva
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to perform bug fixes for v2 APIs