Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed/issue5111 サイトマップ 商品情報出力の際に、在庫切れ非表示オプションを有効にしても表示されるを改修 #5146

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

watarukashii
Copy link
Contributor

@watarukashii watarukashii commented Sep 3, 2021

概要(Overview・Refs Issue)

#5111 サイトマップ 商品情報出力の際に、在庫切れ非表示オプションを有効にしても表示されるを改修

マイナーバージョン互換性保持のための制限事項チェックリスト

  • 既存機能の仕様変更
  • フックポイントの呼び出しタイミングの変更
  • フックポイントのパラメータの削除・データ型の変更
  • twigファイルに渡しているパラメータの削除・データ型の変更
  • Serviceクラスの公開関数の、引数の削除・データ型の変更
  • 入出力ファイル(CSVなど)のフォーマット変更

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

@codecov-commenter
Copy link

Codecov Report

Merging #5146 (67dd61e) into 4.1 (d99f4de) will increase coverage by 0.01%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                4.1    #5146      +/-   ##
============================================
+ Coverage     68.33%   68.35%   +0.01%     
- Complexity     6069     6070       +1     
============================================
  Files           456      456              
  Lines         24941    24945       +4     
============================================
+ Hits          17044    17050       +6     
+ Misses         7897     7895       -2     
Flag Coverage Δ
E2E 57.24% <0.00%> (+0.01%) ⬆️
Unit 76.08% <66.66%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Eccube/Controller/SitemapController.php 79.48% <40.00%> (-1.60%) ⬇️
...ontroller/Admin/Product/ProductClassController.php 80.76% <0.00%> (+0.48%) ⬆️
src/Eccube/Entity/TaxRule.php 86.41% <0.00%> (+1.23%) ⬆️
...orage/Handler/SameSiteNoneCompatSessionHandler.php 91.04% <0.00%> (+2.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d99f4de...67dd61e. Read the comment docs.

@chihiro-adachi chihiro-adachi merged commit 988b60c into EC-CUBE:4.1 Nov 29, 2021
@chihiro-adachi
Copy link
Contributor

@watarukashii
ありがとうございます、マージしました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants