Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "会員登録済みのメールアドレスを判別不可にする" #5460

Merged
merged 4 commits into from
Aug 1, 2022

Conversation

chihiro-adachi
Copy link
Contributor

Reverts #5391

Revertの経緯は以下に記載しています。
#5279 (comment)

@chihiro-adachi chihiro-adachi added this to the 4.2.0 milestone Jul 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022

Codecov Report

Merging #5460 (650be08) into 4.2 (9bafbe4) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                4.2    #5460      +/-   ##
============================================
+ Coverage     78.74%   78.78%   +0.03%     
+ Complexity     6251     6246       -5     
============================================
  Files           468      468              
  Lines         21007    20979      -28     
============================================
- Hits          16543    16528      -15     
+ Misses         4464     4451      -13     
Flag Coverage Δ
E2E 64.39% <92.00%> (+0.06%) ⬆️
Unit 77.04% <92.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Eccube/Controller/EntryController.php 93.75% <100.00%> (+5.35%) ⬆️
src/Eccube/Entity/Customer.php 91.95% <100.00%> (+0.08%) ⬆️
src/Eccube/Form/Type/Admin/CustomerType.php 93.47% <100.00%> (+0.14%) ⬆️
src/Eccube/Service/MailService.php 90.34% <100.00%> (ø)
src/Eccube/Repository/CustomerRepository.php 96.87% <0.00%> (+1.87%) ⬆️
...be/Service/PurchaseFlow/Processor/TaxProcessor.php 78.94% <0.00%> (+3.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bafbe4...650be08. Read the comment docs.

@taguchimasahiro taguchimasahiro merged commit 57322d0 into 4.2 Aug 1, 2022
@taguchimasahiro taguchimasahiro deleted the revert-5391-issue/5279 branch August 1, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants