-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EC-Earth3-ESM-1 #825
Comments
Changes in the |
Is there anything blocking the merge of this branch? It has been open for a few months and we are in the middle of production with this model version. |
I think there is missing the required changes to modify ece2cmor3/scripts/modify-metadata-template.sh ? |
…x. Split source_type array. Add release_year var. #825.
Yes, see 0bd5e26. Sorry this took so long. |
I will start testing this branch with running For co2box I took: |
For the nominal resolution for the |
I have added the PISM component for the metadata part already here, though the PISM cmorisation component is not implemented yet. |
the grid of the co2box moel is a global (0D) one, so it could be gm, but that means a processing from some spatial data to a global average, so gn is fine! |
thats is not quite exact since it's a global grid, but I don't think there is something that fits well, but this works because
|
I processed many experiments for OptimESM, including output from the co2box model, always setting |
What do you think is missing for PISCES? The OptimESM runs were done with PISCES. I have run ece2cmor in spring (plain e5bc947f56c ) and the PISCES output was nicely processed. For example I can find chldiatos = "Surface Mass Concentration of Diatoms Expressed as Chlorophyll in Sea Water" in the cmorised output. |
PISM <=> PISCES ? |
So far I witness only expected changes with running the full |
Then I have to change from:
to
and see whether updating the optimism ECE output control files will go smooth or current manual commits have to be sorted out. Other experiments to be added there? Or is the experiment naming still under discussion - I lost the status on that. |
I see Klaus that in r10143 you chose in metadata-*-co2box-template.json |
(the comment attribute you added I will take over) |
For co2box grid I used now |
Add esm configuration, implement #825
Branch merged into master with #831 |
This is a somewhat unlucky choice. The metadata for the co2box model were suggested in 1312-180, This suggestion was open for discussion but no comments were made so these changes have been comitted (see 1312-216). If you now change these metadata it means that all the data that have been cmorised will be different from those that will be cmorised with newer versions of the metadata template. Unless anybody thinks the old metadata are wrong for any reason I would suggest we revert the changes in the metadata to avoid confusion. |
I just chose something which looked clear to me ;) Same applies to I am fine with any choice, I just want to finish it :) |
Sure, no problem. However, changing metadata violates backward compatibility, something we should avoid if not necessary. Several experiments and members from OptimESM have already been cmorised, so I suggest we stick with the metadata that we used there. |
Set co2box grid metadata to what has been used so far in optimesm #825.
Adjusted in e5d732b |
Add the EC-Earth3-ESM-1 configuration.
See also ECE portal issue 1312-226.
The text was updated successfully, but these errors were encountered: