Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CI to awvwgk/setup-fortran@main #117

Merged
merged 8 commits into from
Nov 4, 2022
Merged

Conversation

wpbonelli
Copy link
Contributor

awvgwk/setup-fortran@main supports a selection of GCC versions on all platforms, with a (hopefully) more future-proof fix for Mac .dylib issues, and runner/version compatibility is tested daily, so we get a heads up if runners change underfoot — plus the maintainer is responsive to PRs. Overall probably better to rely on than modflowpy/install-gfortran-action

also bumped actions/checkout and actions/setup-python to latest major versions

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Merging #117 (739a508) into main (a812e8d) will increase coverage by 0.38%.
The diff coverage is 93.38%.

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   81.20%   81.58%   +0.38%     
==========================================
  Files          39       40       +1     
  Lines        4624     4758     +134     
==========================================
+ Hits         3755     3882     +127     
- Misses        869      876       +7     
Impacted Files Coverage Δ
pynhm/utils/netcdf_utils.py 86.59% <ø> (ø)
pynhm/utils/cbh_utils.py 93.12% <93.12%> (ø)
pynhm/hydrology/PRMSSnow.py 91.27% <100.00%> (+0.05%) ⬆️
pynhm/base/meta.py 79.79% <0.00%> (+2.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmccreight
Copy link
Member

Thanks @w-bonelli!

I think the failure is the race condition to which I need to apply pytest-order. If it persists, i can deal with it separately.

would you mind applying the same changes to .github/workflows/ci_examples.yaml as well? i have to many braches going at once to add another!

@jmccreight
Copy link
Member

actually, i realized what that error is and fixed it via a commit to your dev branch directly. You'll have to pull/fetch it

@wpbonelli
Copy link
Contributor Author

sure thing! let me know if there's anything else to tack on here

@jmccreight
Copy link
Member

I just merged to upstream/main, so you'll have to merge that again too. But that should do it.
thanks!

@wpbonelli wpbonelli marked this pull request as ready for review November 4, 2022 20:08
@jmccreight jmccreight merged commit 73dde34 into EC-USGS:main Nov 4, 2022
@wpbonelli wpbonelli deleted the develop branch November 4, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants