Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat run param sep #188

Merged
merged 57 commits into from Jun 30, 2023
Merged

Conversation

jmccreight
Copy link
Member

@jmccreight jmccreight commented Jun 7, 2023

This PR

  1. separates NHM/PRMS parameters using the Parameter class.
  2. Introduces dis_hru and dis_seg for the nhm as special "discretization" subsets of the NHM/PRMS
  3. Keeps Model backwards compatible with a single PrmsParameter object being passed
  4. Updates Model to take a list of discretizations and processes along with their individual data.

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023

Codecov Report

Merging #188 (32d905e) into develop (b86e4bb) will increase coverage by 2.17%.
The diff coverage is 94.62%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop     #188      +/-   ##
===========================================
+ Coverage    77.34%   79.52%   +2.17%     
===========================================
  Files           50       51       +1     
  Lines         6364     6421      +57     
===========================================
+ Hits          4922     5106     +184     
+ Misses        1442     1315     -127     
Impacted Files Coverage Δ
pywatershed/analysis/model_graph.py 11.01% <25.00%> (+0.58%) ⬆️
pywatershed/parameters/starfit_parameters.py 28.12% <40.00%> (+2.31%) ⬆️
pywatershed/hydrology/starfit.py 29.76% <80.00%> (ø)
pywatershed/utils/path.py 81.81% <81.81%> (ø)
pywatershed/base/parameters.py 90.00% <86.36%> (-3.11%) ⬇️
pywatershed/base/conservative_process.py 89.85% <89.85%> (ø)
pywatershed/base/control.py 92.80% <92.00%> (-0.54%) ⬇️
pywatershed/hydrology/prms_snow.py 90.45% <94.11%> (ø)
pywatershed/hydrology/prms_soilzone.py 88.19% <95.00%> (ø)
pywatershed/base/model.py 94.73% <95.12%> (-0.51%) ⬇️
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmccreight jmccreight mentioned this pull request Jun 23, 2023
4 tasks
@jmccreight
Copy link
Member Author

Does this address #145?

@jmccreight jmccreight mentioned this pull request Jun 27, 2023
1 task
@jmccreight jmccreight merged commit 256dfbf into EC-USGS:develop Jun 30, 2023
10 checks passed
@jmccreight jmccreight deleted the feat_run_param_sep branch July 7, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run NHM processes with separate parameters
2 participants