Feature/add clock support #24

lleon95 · 2024-05-10T17:57:10Z

This feature:

Adds clock query and setting to the US+, so the accelerators can run at its nominal frequency
Adds a debug class
Fixes warnings regarding unused macros

dierpg

overall code is pretty clean, not sure about that uint though, maybe theres something im not seeing.

include/cynq/debug.hpp

src/cynq/ultrascale/hardware.cpp

This adds a basic logging tool for development

This adds a new function to read the PL clocks

Now, the platform supports clocking so we can use a proper clock for our IPs

Matmul illustrates how to clock the platform properly

There were some warnings complaining about unused variables

Integrate the clock functions

This fixes the retroactive comments from the previous PR

There were repeated constants. All were factorised out

It was not clear in the example

This adds clocks information

This adequates doxygen to use the right one

This avoids errors in storing the addresses when using just uint

lleon95 requested a review from dierpg May 10, 2024 17:57

lleon95 self-assigned this May 10, 2024

lleon95 mentioned this pull request May 10, 2024

CYNQ clocking issues #23

Closed

lleon95 force-pushed the feature/add-clock-support branch from bb919ab to 8a35589 Compare May 11, 2024 08:40

dierpg reviewed May 14, 2024

View reviewed changes

include/cynq/debug.hpp Outdated Show resolved Hide resolved

src/cynq/ultrascale/hardware.cpp Outdated Show resolved Hide resolved

lleon95 added 13 commits June 1, 2024 10:59

Merge branch 'feature/add-queue-support' into develop

ff21413

Add debug tool

90b179d

This adds a basic logging tool for development

Add first concept of clock determination

5193af7

This adds a new function to read the PL clocks

Add clock setting support

1c63d85

Now, the platform supports clocking so we can use a proper clock for our IPs

Add an example in matmul

2364fec

Matmul illustrates how to clock the platform properly

Fix the unused variables

fdf0e00

There were some warnings complaining about unused variables

Update class diagram

02fc4d0

Integrate the clock functions

Fix comments to be more complete

df51689

This fixes the retroactive comments from the previous PR

Factorise code from clocks

9628ed2

There were repeated constants. All were factorised out

Add more information to the matrix multiplication addresses

d172ae7

It was not clear in the example

Enhance documentation

828bb18

This adds clocks information

Update documentation syntax

c6ff7f9

This adequates doxygen to use the right one

Fix addresses to be 64-bit

15b78ce

This avoids errors in storing the addresses when using just uint

lleon95 force-pushed the feature/add-clock-support branch from 4879781 to 15b78ce Compare June 1, 2024 11:00

lleon95 closed this Jun 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/add clock support #24

Feature/add clock support #24

lleon95 commented May 10, 2024

dierpg left a comment

Feature/add clock support #24

Feature/add clock support #24

Conversation

lleon95 commented May 10, 2024

dierpg left a comment

Choose a reason for hiding this comment