Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add Missing Regression Analysis (NCI corrector) #3252

Merged
merged 1 commit into from
Jul 22, 2022
Merged

CI: Add Missing Regression Analysis (NCI corrector) #3252

merged 1 commit into from
Jul 22, 2022

Conversation

EZoni
Copy link
Member

@EZoni EZoni commented Jul 21, 2022 •
edited
Loading

While debugging #3222, I could not understand the behavior of two CI tests, nci_corrector and nci_correctorMR, namely why the regression analysis would always pass despite some changes that should have affected the checksums.

It turns out that the regression analysis was not done for these tests and no checksum JSON files were available.

Was the regression analysis avoided intentionally for these two tests, or was this simply overlooked by mistake? Could not find a PR that removed them, seems like they were simply not added since the beginning.

@EZoni EZoni added the component: tests Tests and CI label Jul 21, 2022
@EZoni EZoni mentioned this pull request Jul 22, 2022
Merged
6 tasks
@EZoni EZoni requested a review from ax3l July 22, 2022 18:06
@ax3l ax3l added bug Something isn't working bug: affects latest release Bug also exists in latest release version labels Jul 22, 2022
ax3l
ax3l approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - this looks indeed like a test bug to me.

@ax3l ax3l merged commit a4be769 into ECP-WarpX:development Jul 22, 2022
@ax3l ax3l self-assigned this Jul 22, 2022
@EZoni EZoni deleted the ci_ncicorr_regression branch July 22, 2022 22:01
dpgrote pushed a commit to dpgrote/WarpX that referenced this pull request Jul 23, 2022
@EZoni @dpgrote
CI: Add Missing Regression Analysis (NCI corrector) (ECP-WarpX#3252)
ae6eb73
dpgrote pushed a commit to RemiLehe/WarpX that referenced this pull request Jul 30, 2022
@EZoni @dpgrote
CI: Add Missing Regression Analysis (NCI corrector) (ECP-WarpX#3252)
b03bea7
@NeilZaim NeilZaim mentioned this pull request Aug 9, 2022
Open
ax3l added a commit that referenced this pull request Dec 21, 2022
@dpgrote @pre-commit-ci
@ax3l @RemiLehe @lucafedeli88 @NeilZaim @WeiqunZhang @roelof-groenewald @EZoni
Add accelerator lattice, starting with quadrupoles (#3063)
8985852 
* Initial version of accelerator lattice

* Clean up EOL white space

* Small clean up for GPU

* Fixed up consts

* Added hard edge fraction plus other clean ups

* More clean up

* Restructure to work on GPUs

* Now this grabs its own copies of particle info

* Updates, including adding dBdx

* Small cleanup in Quad

* Small fixes for GPU

* More cleanup for GPU

* More GPU cleanup

* Rewrite of the accelerator lattice implementation to better handle GPU

* Fix struct forward definition

* Another forward definition fix

* Bug fix

* Added LatticeElementBase

* Removed zcenters array

* Added CI test case

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Clean up in CI analysis.py

* Cleanup of coding

* Added CI test hard_edged_quadrupoles_moving

* Added Lorentz transform between boosted frame and lab frame

* Fixes for working in the boosted frame

* Added boosted CI test

* Change input name, adding the prefix "lattice."

* Added plasma lens lattice element

This will replace the external field plasma lens

* Fixed CI analysis script to look for "lattice.quad"

* Added checks of lattice element input

* Added documentation

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Removed duplicate call to lattice finder UpdateIndices

* Added extensive comments

* Reworked the input to use the MAD like description

This is the same as the method used in ImpactX

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Remove old lines from inputs_lattice_3d

* Added "lattice" element type

* Fixed some Real and ParticleReals

* [pre-commit.ci] pre-commit autoupdate (#3246)

updates:
- [github.com/hadialqattan/pycln: v2.0.1 → v2.0.3](hadialqattan/pycln@v2.0.1...v2.0.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* ABLASTR: Update Poisson Solver API (#3243)

Update the Poisson Solver API to be more usable. Needed for ImpactX.

* Docs: New OLCF Machine (#3228)

* D-T fusion (#3153)

* initial work

* fixed bugs and added species

* update documentation

* delete unused file

* Add properties for neutron, hydrogen isotopes, helium isotopes

* Update code to be more consistent

* Correct typo

* Parse deuterium-tritium fusion

* Start putting in place the files for deuterium-tritium

* Update documentation

* Prepare structures for deuterium tritium

* Fix typo

* Fix compilation

* Add neutron

* Add correct formula for the cross-section

* Correct compilation error

* Fix nuclear fusion

* Reset benchmarks

* Prepare creation functor for 2-product fusion

* First implementation of momentum initialization

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Use utility function for fusion

* Minor modification of variable names

* Fix GPU compilation

* Fix single precision compilation

* Update types

* Use util function in P-B fusion

* Correct compilation errors

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Correct errors

* Update values of mass and charge

* Correct compilation error

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Correct compilation error

* Correct compilation error

* Correct compilation error

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Reset benchmark

* Use helium particle in proton-boron, to avoid resetting benchmark

* Fixed proton-boron test

* Revert "Fixed proton-boron test"

This reverts commit 73c8d9d.

* Incorporate Neil's recommendations

* Reset benchmarks

* Correct compilation errors

* Add new deuterium tritium automated test

* Correct formula of cross-section

* Correct cross-section

* Improve analysis script

* Add test of energy conservation

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add test of conservation of momentum

* Progress in analysis script

* Fix error in the initial energy of the deuterium particles

* Add check of isotropy

* Clean up the test script

* Rewrite p_sq formula in a way to avoids machine-precision negative numbers

* Add checksum

* Clean up code

* Apply suggestions from code review

* Update PR according to comments

* Update benchmark

* Address additional comments

* Numerical Literals

Co-authored-by: Luca Fedeli <luca.fedeli@cea.fr>
Co-authored-by: Neïl Zaim <49716072+NeilZaim@users.noreply.github.com>

* Docs: gaussian beam `q_tot` is not optional (#3249)

* Fix a bug in GPU version of Hankel Transform (#3253)

amrex::Array4 is a 4D array that can be accessed with three spatial indices
plus an optional component index.  We must always provide all three spatial
indices even in 2D.

* Add Python Callback Call when Checkpointing Signal is Received (#3251)

* CI: Add Missing Regression Analysis (NCI corrector) (#3252)

* Fixes to allow mixed precision, ParticleReal float, Real double (#3239)

* Fixes to allow mixed precision, ParticleReal float, Real double

* Fix for the optical depth

* A different way of fixing QuantumSynchrotronEvolveOpticalDepth

* In the QED code, consistently use ParticleReal

* Use ParticleReal type consistently

* Fix typo Docs/source/usage/parameters.rst

Co-authored-by: Edoardo Zoni <59625522+EZoni@users.noreply.github.com>

* Fix typo Docs/source/usage/parameters.rst

Co-authored-by: Edoardo Zoni <59625522+EZoni@users.noreply.github.com>

* Fix small error in plasma lens lattice documentation

* Small addition to the documentation

* Fix the residence correction to allow short elements

* Updated CI benchmarks

* Added check of lattice to isNoOp

* Updated the hard_edged_quadrupoles CI benchmarks

It is not clear why there was a change, but the difference is
essentially round off in the E field. The important thing is that the
particles are still correct.

* Update Source/AcceleratorLattice/AcceleratorLattice.H

Add include statements

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/AcceleratorLattice/LatticeElements/LatticeElementBase.H

Add includes

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Renamed to README.rst and updated headers

* Made d_lattice_element_finder optional type

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Include `<optional>`

* Docs: Developer AccLattice Inclusion

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
Co-authored-by: Luca Fedeli <luca.fedeli@cea.fr>
Co-authored-by: Neïl Zaim <49716072+NeilZaim@users.noreply.github.com>
Co-authored-by: Weiqun Zhang <WeiqunZhang@lbl.gov>
Co-authored-by: Roelof Groenewald <40245517+roelof-groenewald@users.noreply.github.com>
Co-authored-by: Edoardo Zoni <59625522+EZoni@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: tests Tests and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EZoni @ax3l