Enable multiple devices and fix CudaSpace #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sslattery
approved these changes
Jun 4, 2020
| pack_indicies_all = Kokkos::View<T_INT **, Kokkos::LayoutRight, DeviceType>( | ||
| "CommMPI::pack_indicies_all", 6, 200 ); | ||
| pack_ranks_all = Kokkos::View<T_INT **, Kokkos::LayoutRight, DeviceType>( | ||
| pack_count = Kokkos::View<int, Kokkos::LayoutRight, device_type>( |
There was a problem hiding this comment.
why are some of these views int and others T_INT?
There was a problem hiding this comment.
Looks like a holdover from ExaMiniMD. I've been meaning to go through and make sure these are all consistent
This was referenced Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR templates the
Systemclass (and NNPModeclass) on the device type so that the library can be built with all available Kokkos devices and the executable can use any at runtime. Previously, the default device was used everywhere, chosen at compile time.This also addresses issues in initialization (lattice and velocity creation) with
CudaSpace, now done on the host explicitly and copied to the device, with a newSystem::deep_copyfor all AoSoAs. Previously,CudaUVMSpacewas used.