Em #32
Merged
Em #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
resolves #28 |
One PR should resolve one issue because when we have to revert we can't revert separately. @Shubhambawner revert #27 changes and keep this PR as #28 only. |
sahil9001
requested changes
Oct 16, 2022
Oh yes, after some examination I found that issue 27 is independent. initially it was incorrectly linked. |
|
@AyushAgrawal25 I haven't tested these files but looks good to me, can you check it? |
AyushAgrawal25
approved these changes
Oct 25, 2022
AyushAgrawal25
requested changes
Oct 25, 2022
There was a problem hiding this comment.
Change the base_url at axios.js to https://ecellbackend.tech/, currently it's causing merge issue.
Shubhambawner
requested review from
AyushAgrawal25
and removed request for
sahil9001
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Team page updated
now its more dynamic, componentised, and error tollerent.
EM added.