Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inara: Review current API docs and ensure we send all that we can and should #1433

Closed
Athanasius opened this issue Feb 4, 2022 · 1 comment · Fixed by #2212
Closed

Inara: Review current API docs and ensure we send all that we can and should #1433

Athanasius opened this issue Feb 4, 2022 · 1 comment · Fixed by #2212
Assignees
@Rixxan
Labels
bug enhancement Inara Staged Feature Complete and in Testing for Next Release
Milestone
5.11

Comments

@Athanasius
Copy link
Contributor

NB: Tagged as both an Enhancement and a Bug because I wouldn't be surprised if we do have unreported bugs due to not having done this.

With reference to #1395 we probably aren't making use of all the possible Inara API messages we could be.

We need to do a general review of the Inara API Docs and implement anything that's possible to ensure we give users the best "sync with Inara" experience.
@Athanasius Athanasius added this to the 5.4.0 milestone Feb 4, 2022
@Athanasius Athanasius mentioned this issue Feb 4, 2022
Closed
@Athanasius Athanasius modified the milestones: 5.5.0, 5.4.0 Feb 5, 2022
@Athanasius Athanasius removed this from the 5.5.0 milestone Feb 8, 2022
Athanasius added a commit that referenced this issue Dec 1, 2022
@Athanasius
Inara: Drop addCommanderCombatInterdicted if empty opponentName
2bbda30 
Addresses #1732 specifically.

At some point #1433 needs fully addressing (review all Inara API code for
compliance with docs).
@Athanasius Athanasius mentioned this issue Dec 1, 2022
Merged
@Rixxan Rixxan modified the milestones: Pre-6.0 Changes, 5.11.0 Dec 21, 2023
@Rixxan Rixxan linked a pull request May 14, 2024 that will close this issue
[1654] Add Ship Jump Range and Cargo Capacity to Inara #2212
Merged
@Rixxan
Copy link
Contributor

Rixxan commented May 14, 2024

I think we are sending everything in the API to my knowledge. I don't see any further filtering we need to make at this time. At least, not until someone reports something missing to us.

Last bits in #1735 and #2212 seem to cover everything. Adding Staged label and marking as resolved in 5.11.

@Rixxan Rixxan self-assigned this May 14, 2024
@Rixxan Rixxan added the Staged Feature Complete and in Testing for Next Release label May 14, 2024
@Rixxan Rixxan closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rixxan Rixxan

Labels
bug enhancement Inara Staged Feature Complete and in Testing for Next Release
Projects
Enhancement Tracker
Status: Complete
Milestone
5.11
Development

Successfully merging a pull request may close this issue.

[1654] Add Ship Jump Range and Cargo Capacity to Inara HullSeals/EDMarketConnector
2 participants
@Athanasius @Rixxan