Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inara plugin attempts to send empty/zero Major Reputation #581

Closed
Athanasius opened this issue Jul 11, 2020 · 3 comments
Closed

Inara plugin attempts to send empty/zero Major Reputation #581

Athanasius opened this issue Jul 11, 2020 · 3 comments
Assignees
@Athanasius
Labels
bug Plugins Anything related to plugins

Comments

@Athanasius
Copy link
Contributor

After filling in Inara API Key for new second account I saw this on the EDMC status line:

Error: Inara setCommanderReputationMajorFaction, No reputation value provided.

The code should check this and just not attempt to send.
@Athanasius Athanasius mentioned this issue Jul 11, 2020
Open
@Athanasius Athanasius added bug Plugins Anything related to plugins labels Jul 11, 2020
@Athanasius
Copy link
Contributor Author

Athanasius commented Jul 11, 2020 •
edited
Loading

Update https://github.com/EDCD/EDMarketConnector/wiki/New-user-guide when fixed.

This was referenced Jul 15, 2020
Open
Open
@Athanasius
Copy link
Contributor Author

The Journal event is literally just:

{ "timestamp":"2021-04-05T11:00:55Z", "event":"Reputation" }

This means monitor.state['Reputation'] has likely all zeroes. So catch that and don't try to send the zeroes.

@Athanasius Athanasius self-assigned this Apr 5, 2021
Athanasius added a commit that referenced this issue Apr 6, 2021
@Athanasius
Inara: Don't send a setCommanderReputationMajorFaction if we have no …
67fcfa5 
…Reputations

Sure the `for k, v in ...` means not sending any that are empty/none,
but it will still send the event, just with *no* reputations.

When you're on a fresh character you have no reputations yet, so avoid
causing an Inara API error, including status line text.

Close #581
@Athanasius
Copy link
Contributor Author

Fix will be in 5.0.0-beta5.

Athanasius added a commit that referenced this issue Apr 12, 2021
@Athanasius
Inara: Don't send a setCommanderReputationMajorFaction if we have no …
9fd14a3 
…Reputations

Sure the `for k, v in ...` means not sending any that are empty/none,
but it will still send the event, just with *no* reputations.

When you're on a fresh character you have no reputations yet, so avoid
causing an Inara API error, including status line text.

Close #581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Athanasius Athanasius

Labels
bug Plugins Anything related to plugins
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Athanasius