Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible breaking change in upcoming usmap 0.6.0 #136

Closed
pdil opened this issue Feb 25, 2022 · 2 comments
Closed

Possible breaking change in upcoming usmap 0.6.0 #136

pdil opened this issue Feb 25, 2022 · 2 comments

Comments

@pdil
Copy link

pdil commented Feb 25, 2022

I'm the maintainer of the usmap which is used in ecocomDP and wanted to warn that the next version of usmap (0.6.0 coming in the next few weeks) contains a breaking change in the usmap_transform package.

In order to provide more flexibility of input data, a new parameter (input_names) has been added to specify the longitude and latitude column names of the input data.

I found that this line in particular may require a change:

transformed_cleaned <- suppressWarnings(usmap::usmap_transform(cleaned))

Since the data specified here:
https://github.com/EDIorg/ecocomDP/blob/5a919749b147635e15640af1646398f650180f30/R/plot_taxa.R#L1311-#L1315
uses longitude and latitude column names, the usmap_transform code will have to be changed to:

transformed_cleaned <- suppressWarnings(usmap::usmap_transform(cleaned, input_names = c("longitude", "latitude")))

Note this change will only be required after 0.6.0 is released. If desired, I can notify here when that happens.

For more information, see: pdil/usmap#53

@clnsmth
Copy link
Contributor

clnsmth commented Feb 28, 2022

Thanks for the notification @pdil.

@sokole Would you mind submitting a PR for this and the possibly related CRAN Package Check Errors? The fix needs to be on CRAN before 2022-03-13 or ecocomDP will be removed. Many thanks!

clnsmth added a commit that referenced this issue Mar 5, 2022
Fix plot_sites() to work with version 0.6.0 of the usmap package. See ecocomDP issue #136.
@clnsmth
Copy link
Contributor

clnsmth commented Mar 7, 2022

The fixes are in and version 1.2.1 of ecocomDP released on CRAN.

@clnsmth clnsmth closed this as completed Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants