Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Disable/Enable ruleset window gone #2258

Closed
ghost opened this issue Jul 18, 2015 · 27 comments
Closed

Disable/Enable ruleset window gone #2258

ghost opened this issue Jul 18, 2015 · 27 comments

Comments

@ghost
Copy link

ghost commented Jul 18, 2015

The disable/enable window was removed in #2121 (v 5.0.6 later). As already mentioned in #1609 IMO this is not optimal.
It was such nice to see what sites/services are supported. Okay you can do this with Atlas too, but there it is much less uncomfortable.

Some things I liked with the rules window, which we lost now:

  • ability to search/filter addons (with Atlas you have to click on the first letter of the name - that's terrible UX compared to the search feature 😢)
  • ability to just right click and show the XML source directly from the addon (this was nice for quickly debugging/looking into a ruleset, now you have to visit Atlas for this and look for the correct ruleset there, which is annoying)
  • an overview over which rules you have enabled and disabled

Besides this also Atlas is not linked from the addon (about page or somewhere else), so many users, which previously used the ruleset window, maybe do not find it.

@jsha
Copy link
Member

jsha commented Jul 18, 2015

You make some good points. We should definitely link and promote the Atlas better. And its UI should certainly be improved! You actually can search for rulesets in the Atlas, you just have to type in the big query box with no label. :-)

I would definitely like to add back the ability to view source directly from the addon, probably as a link from the rulesets that show up in the icon menu when you are on a given site.

@ghost
Copy link
Author

ghost commented Jul 18, 2015

You actually can search for rulesets in the Atlas, you just have to type in the big query box with no label. :-)

😲 Oh yes you're right. So I think about this box and UX you don't have to say more.

I would definitely like to add back the ability to view source directly from the addon, probably as a link from the rulesets that show up in the icon menu when you are on a given site.

Yes somehow like this would be good.

BTW about "an overview over which rules you have enabled and disabled" I think also a display of all rules where you (=the user) toggled the state would be enough - so you can see, which rules you modified.

@ghost
Copy link

ghost commented Aug 8, 2015

So, if the (useful) ruleset window is gone, the links to it in the toolbar and tools menu should be removed as well. Shouldn't they?

@jsha
Copy link
Member

jsha commented Aug 10, 2015

I left the "Enable / disable rules" text in the toolbar menu as an indicator of what clicking the menu items below it will do. I forgot to give it the disabled property so it looks less like a menu item itself; that's coming in a future release. I'm also very open to changes in wording or UI that will achieve the same goal more clearly.

Also, I'd like to hear more about your use case for the ruleset window, to see if I can meet it some other way. Does the HTTPS Everywhere Atlas help? https://www.eff.org/https-everywhere/atlas/

@ghost
Copy link

ghost commented Aug 15, 2015

Hi jsha

The ruleset window provided a nice overview of all the rules, but It seems like the atlas page does this as well.

@rezad1393
Copy link

so it is definitely gone?
that is not good.
now I have no way of knowing enabled and disable websites before I visit them.
no I am not talking about what rules are in Atlas website are.
I am talking about my version of addon installed on my computer which can be offline and can differ from the latest rules in Atlas.( as far as I know rules are packaged in addon and are not updated or loaded separately from Atlas website, which would be better , but that's another matter).

now if I want to check to see what rules are disable by default or by my modification I have no way of seeing that.
also I have a lot of rules added by https finder addon and they definitely are not in Atlas.and I cant see their state anymore .
I understand the lookup of browser when opening the rules window but couldn't it be still there but hidden and as a alternative to Atlas?
this is sad.

@ghost
Copy link
Author

ghost commented Sep 1, 2015

( as far as I know rules are packaged in addon and are not updated or loaded separately from Atlas website, which would be better , but that's another matter).

cross reference: #2605 😉

I have a lot of rules added by https finder addon and they definitely are not in Atlas.and I cant see their state anymore .

Good argument. I haven't thought about this earlier.
I mean you can see there state in the context menu, but you have to visit the site before you can do this, so I understand that a rules overview would be better.

@ghost
Copy link
Author

ghost commented Sep 1, 2015

As for a reimplementation of the rulesets list one small suggestion: Use a tab page.
This way you easily have a flexible windows and I think, because of the HTML basis it should be easily (or at least easier) to create (than the old window) and is possibly more robust than the old one (preventing things like #1609).
This would be the same approach which is also used by the new version of Privacy Badger, which display the detected trackers in a new tab.

@ghost
Copy link
Author

ghost commented Sep 29, 2015

rezad1393 commented
so it is definitely gone?
that is not good.
now I have no way of knowing enabled and disable websites before I visit them.

I agree with rezad1293 here, without the Preferences menu, as it was called. There is no meaningful way to use the addon anymore. I need the search function in the extension and the ability to change rules before I visit a site.

Since this issue is being ignored the only way is downgrading to an old version, turning off upgrades and risking having less protection. I recommend everyone doing the same. They won't learn until new installs go down.

menu

@vicgarin
Copy link

vicgarin commented Nov 6, 2015

@jsha How do I Enable and Disable my custom rulesets now?

@margentieri
Copy link

Completely removing this functionality has damaged the usability of this addon, and has FORCED me to downgrade to 3.4.5 to retain the preferences window. You are ignoring the fact that not all sites that are being converted to an HTTPS connection are actually that of the website being visited, and therefore do not show up as options to check or uncheck on the site. A prime example is Netflix, which uses Silverlight to play their videos and provide DRM. Silverlight needs to communicate with Microsoft, but none of Microsoft's websites are listed on the dropdown when you are on Netflix's site. Without disabling HTTPS Everywhere for Microsoft, Silverlight fails to properly communicate with Microsoft, and the site will not play ANY videos. In the past, I simply had to go into the addon's settings, search for Microsoft, and uncheck it. Now I can't do that, which completely breaks Netflix. I should note that I am using Firefox on Ubuntu Linux, not Windows or Mac. Functionality in an addon like this should never be totally removed for the sake of convenience or the laymen. If you want to remove it from sight for the laymen, fine, but at least provide a means to re-enable it though an expert mode check box or an about:config setting that can be changed.

@rugk
Copy link
Contributor

rugk commented Jan 2, 2016

This is completely off-topic, but just FYI: For watching videos on Netflix with Firefox you do not need Silverlight anymore.
But as I see you use Linux I have to say that on Linux this does not work currently AFAIK as you do not have Adobes Content Decryption Module here.

@margentieri
Copy link

Hi @rugk, yes I am aware that Firefox HTML5 can play Netflix videos, but this option is currently only available on Windows machines, which forces me to use Pipelight instead (Pipelight being a Linux port of Silverlight)

@rugk
Copy link
Contributor

rugk commented Jan 2, 2016

Okay and as a a reference: The Silverlight issue seems to be tracked in #1767.

@margentieri
Copy link

Thanks, but personally I don't see this so much as a bug as I do it being an issue with a specific site that I would just need to manually fix myself by disabling HTTPS connections with Microsoft. The issue I see here is that my ability to make this kind of fix has been completely removed. Netflix and Silverlight was just an example. If this kind of issue is present with Netflix, it would not surprise me to find the same kind of issue elsewhere. The only way to fully address this kind of issue is to enable users to both see AND modify the HTTPS settings for every site without having to first visit them, as was the case before the HTTPS Everywhere preferences page was removed.

@rugk
Copy link
Contributor

rugk commented Jan 3, 2016

I don't really know the details but AFAIK all connections a site makes and which are redirected/influenced by HTTPS-Everywhere should appear in the context menu of the icon.
Once it is disabled it of course applies to all sites.

@margentieri
Copy link

If that were true, then Microsoft would show up on Netflix due to the Silverlight connection; however, this is not the case. Silverlight DOES need to connect to Microsoft for DRM, this is known, so the fact that HTTPS Everywhere disturbs this connection proves it is redirecting/influencing that connection, especially since disabling Microsoft in the HTTPS Everywhere preferences fixes the issue.

@rugk
Copy link
Contributor

rugk commented Jan 5, 2016

Well... the only explanation would be that Silverlight itself accesses Microsoft, but the HTTPS Everywhere filter usually do not affect plugins so this is really strange.

@margentieri
Copy link

Understood, but again... That was just an example. A useful feature such as this should not be totally removed. Hide it if you want, maybe only make it accessible through altering an about:config setting, but don't completely remove its utility for those of us who know what we are doing and have use of it. Total removal of a feature for the sake of the layman is a horrible horrible philosophy to develop with. At the very least, as @rezad1393 pointed out, as Atlas only shows the default rules, I now no longer have any means to view which rules I have manually added or disabled myself unless I visit the site, and if I'm interested in a list of which custom rules I have... Am I supposed to try and visit every website I've ever visited so I can check what shows up on that stupid drop down menu?

@jsha
Copy link
Member

jsha commented Feb 1, 2016

To clarify: We removed this feature because it required ongoing maintenance disproportionate to its usefulness. With the large number of rules we have today, the preference window was crashing people's browsers, and the only reasonable course was to take it out.

If you'd like to view your custom rulesets, they are in the same place you created them: under the HTTPSEverywhereUserRules directory of your Firefox profile.

@rezad1393
Copy link

then to disable and enable my own custom rules I have to go to that directory then find and move out the needed rules files and and then "disable https everywhere" and then enable it again , just to check to see the effect?

brilliant.

@jsha
Copy link
Member

jsha commented Feb 1, 2016

No, your custom rules should show up in the drop-down menu when you visit a site that they affect. You can then enable or disable them from the drop-down.

Is the issue that you are modifying your custom rules and need an easy way to reload them after modification?

@rezad1393
Copy link

please try your own solution and see if it works for you .
doesn't work for me for custom rules.just for default rules.

@rugk
Copy link
Contributor

rugk commented Feb 1, 2016

Indeed I have to confirm that you cannot enable or disable custom rulesets. I thought this was a known issue and is just not implemented or something like this.
Should I open a new issue about this?

Tried with Firefox 44

@jsha
Copy link
Member

jsha commented Feb 5, 2016

Thanks for pointing that out. I thought we had fixed that a while ago. It's possible we fixed a different bug and then regressed. Anyhow, the custom rule enable/disable bug should now be fixed in #4095.

@mzso
Copy link

mzso commented May 28, 2016

@Alice-Margatroid

the only way is downgrading to an old version, turning off upgrades and risking having less protection. I recommend everyone doing the same.

Hi!
Do you know where to get the old version? Is really 5.0.6 the latest with this manage window?

@pipboy96
Copy link
Contributor

This issue is specific to pre-WebExtensions Firefox version. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants