Remove Enable / Disable rules window.

[jsha]

Loading all the rulesets at once for the Enable / Disable rules window
causes browser lockup and sometimes crashes. All of the functionality
in the window is now available in other places: Rules can be enabled
and disabled directly from the drop down menu. "Disable all" is
available as the menu item "Disable HTTPS Everywhere." And viewing
the source of rulesets is available through the HTTPS Everywhere Atlas.

The one missing piece of functionality was "Reset rulesets to defaults," which I
moved to a menu item.

Now, the preferences link in Firefox's Add-On pane will take you to the SSL
Observatory preferences.

Fixes #1771
Fixes #1683

[pde]

Logically, it seems this option should be in the same menu subsection as the ruleset togglers...

[jsha]

You spotted my corner cutting. The problem is, the string for "Reset to defaults" is in the .dtd locale file (accessible only from XUL), but the menu subsection with the ruleset togglers is built dynamically in Javascript. I considered porting over the "Reset to defaults" string into the .properties locale file so it can be accessed from Javascript, but it didn't seem worth the time.

[pde]

Overall this looks okay, though if there was an easy way to visually indicate that "Enable / Disable rules" is now a heading, and not an option of its own, that would be desirable.

[jsha]

I'm going to go ahead and merge this for the upcoming release, and possible nice-ify the layout for a subsequent release.

[ghost]

Nothing but inane changes because old hardware cannot handle it.

Why not implement an "Expert mode" for people capable of making such decisions to load a "slow" but meaningful preferences window?

[berrythesoftwarecodeprogrammar]

i agree. seems like clicking the entries in the dropdown menu doesnt even work most of the time anymore

[margentieri]

This is insanely stupid. Completely removing this functionality has damaged the usability of this addon, and has FORCED me to downgrade to 3.4.5 to retain the preferences window. You are ignoring the fact that not all sites that are being converted to an HTTPS connection are actually that of the website being visited, and therefore do not show up as options to check or uncheck on the site. A prime example is Netflix, which uses Silverlight to play their videos and provide DRM. Silverlight needs to communicate with Microsoft, but none of Microsoft's websites are listed on the dropdown when you are on Netflix's site. Without disabling HTTPS Everywhere for Microsoft, Silverlight fails to properly communicate with Microsoft, and the site will not play ANY videos. In the past, I simply had to go into the addon's settings, search for Microsoft, and uncheck it. Now I can't do that, which completely breaks Netflix. I should note that I am using Firefox on Ubuntu Linux, not Windows or Mac. Functionality in an addon like this should never be totally removed for the sake of convenience or the laymen. If you want to remove it from sight for the laymen, fine, but like alice-margatroid suggested, at least provide a means to re-enable it though an expert mode check box or an about:config setting that can be changed.