Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete fbclid parameter from facebook's urls #2207

Merged
merged 2 commits into from
Nov 27, 2018

Conversation

julio-b
Copy link
Contributor

@julio-b julio-b commented Oct 29, 2018

Facebook added this tracking parameter a few days ago. With this commit privacybadger deletes it after link unwrapping.

See https://news.ycombinator.com/item?id=18275061 and http://thisinterestsme.com/facebook-fbclid-parameter/

Copy link
Member

@ghostwords ghostwords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bcyphers
Copy link
Contributor

If we want to do #2162 as well, I think it makes sense to merge them into the same PR.

Otherwise, this is an easy win and I'll +1 it. Thanks for the contribution!

@ghostwords
Copy link
Member

@bcyphers If this looks good to you, why make it wait on something else? #2162 sounds good but has greater potential for breakage. This can be in the next release; #2162 probably won't be.

Copy link
Contributor

@bcyphers bcyphers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, let's get this merged then.

@bcyphers bcyphers merged commit e2fbae4 into EFForg:master Nov 27, 2018
@ghostwords ghostwords added the first-party relating to first-party scripts label May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-party relating to first-party scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants