Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project name and project domain name #190

Merged
merged 3 commits into from
Oct 21, 2020
Merged

Add project name and project domain name #190

merged 3 commits into from
Oct 21, 2020

Conversation

enolfc
Copy link
Contributor

@enolfc enolfc commented Apr 1, 2020

Summary

Adds the project name and project domain name for easing discovery

Related issue : #186

@enolfc
Copy link
Contributor Author

enolfc commented Apr 1, 2020

Tests are missing...

@enolfc enolfc marked this pull request as ready for review April 2, 2020 11:08
@enolfc enolfc requested a review from gwarf April 2, 2020 11:08
gwarf
gwarf previously approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@gwarf gwarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enolfc
Copy link
Contributor Author

enolfc commented Jul 22, 2020

pushed simple change to retrigger QA

@gwarf
Copy link
Member

gwarf commented Jul 22, 2020

I wonder if we should wait more for the two missing checks... What's your opinion @enolfc ?

@enolfc
Copy link
Contributor Author

enolfc commented Jul 22, 2020

I wonder if we should wait more for the two missing checks... What's your opinion @enolfc ?

codacy is completely optional, can be even removed
jenkins... unsure, are we really using it?

gwarf
gwarf approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@gwarf gwarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwarf
Copy link
Member

gwarf commented Oct 21, 2020

I've re-triggered a build from Travis, let's see...

@gwarf gwarf merged commit 83beb20 into EGI-Federation:master Oct 21, 2020
@enolfc enolfc deleted the project-name branch August 22, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwarf gwarf gwarf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enolfc @gwarf