Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid use of getchildren #192

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Avoid use of getchildren #192

merged 2 commits into from
Oct 21, 2020

Conversation

enolfc
Copy link
Contributor

@enolfc enolfc commented Oct 21, 2020

Summary

This is deprecated in py2.7 and not available in py3

@enolfc enolfc requested a review from gwarf October 21, 2020 06:39
Copy link
Member

@gwarf gwarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@enolfc
Copy link
Contributor Author

enolfc commented Oct 21, 2020

@gwarf How do we fix all this never completed tests :( ?

@gwarf
Copy link
Member

gwarf commented Oct 21, 2020

So @orviz reached me about the Jenkins part, we will fix it, but in the meantime I've disable dit.
Still we need to have at least the travis part working.
I will also check codacy and potentially disable it too.

@enolfc
Copy link
Contributor Author

enolfc commented Oct 21, 2020

travis was happy about this one. Should be restored

@gwarf
Copy link
Member

gwarf commented Oct 21, 2020

I'm a bit confused with the travis-ci.org vs travis-ci.com and all, and not understanding why the status was again not reaching GitHub.
I've removed the travis checks, and I'm no more allowed to add it as it seems it's lacking feedback from travis since too long.
May need to completely redo travis integration for this repo...

@gwarf
Copy link
Member

gwarf commented Oct 21, 2020

OK, I've randomly unticked and reticked some checkboxes here and there, and now we got the status back working...
We may want to test GitHub actions at some point to rely on one less provider for this.

@gwarf gwarf merged commit bdc6390 into EGI-Federation:master Oct 21, 2020
@enolfc enolfc deleted the xml-fix branch November 9, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants