Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding config for identity:list_users #628

Merged
merged 10 commits into from
Jan 30, 2024
Merged

Adding config for identity:list_users #628

merged 10 commits into from
Jan 30, 2024

Conversation

sebastian-luna-valero
Copy link
Member

Summary

Configuration to enable permissions for EGI.eu staff to execute openstack user list.
This will allow EGI.eu staff to proactively notify creators of long-running VMs and free up resources accordingly.
Many thanks @astalosj and @enolfc for your help!


Related issue :

Co-authored-by: Jan Astalos <73936420+astalosj@users.noreply.github.com>
Co-authored-by: Enol Fernandez <enol.fernandez@egi.eu>

This comment has been minimized.

@sebastian-luna-valero sebastian-luna-valero added the safe for preview Pull request vetted as safe for preview label Jan 29, 2024
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/628

This comment has been minimized.

Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/628

Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/628

Co-authored-by: Baptiste Grenier <baptiste.grenier@egi.eu>
Co-authored-by: Baptiste Grenier <baptiste.grenier@egi.eu>
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/628

Copy link
Contributor

@enolfc enolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should aim for this setting as default so not so much as a separate piece of instructions to follow

content/en/providers/cloud-compute/openstack/aai.md Outdated Show resolved Hide resolved
content/en/providers/cloud-compute/openstack/aai.md Outdated Show resolved Hide resolved
"identity:list_users": "(role:reader and system_scope:all) or (role:reader and domain_id:%(target.domain_id)s)"
```

### Step 1. Change the name of the egi.eu domain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly needed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't set the name of the domain to egi.eu then it's set to domain ID auto-generated when creating the egi.eu identity provider so the other commands with --domain egi.eu won't work (including the user list command). One possibility could be to create the egi.eu domain with correct name before creating the egi.eu identity provider and pass it as parameter to "openstack identity provider create ..." command.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content/en/providers/cloud-compute/openstack/aai.md Outdated Show resolved Hide resolved
Co-authored-by: Jan Astalos <73936420+astalosj@users.noreply.github.com>
Co-authored-by: Enol Fernandez <enol.fernandez@egi.eu>
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/628

Co-authored-by: Jan Astalos <73936420+astalosj@users.noreply.github.com>
Co-authored-by: Enol Fernandez <enol.fernandez@egi.eu>
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/628

Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/628

@sebastian-luna-valero
Copy link
Member Author

The link to:

https://docs.egi.eu/documentation/628/providers/cloud-compute/openstack/vo_config/

from:

https://docs.egi.eu/documentation/628/providers/cloud-compute/openstack/aai/#additional-vos

fails in the tests but works in the preview.

I think this happened in the past but cant' remember what the solution was.

@enolfc
Copy link
Contributor

enolfc commented Jan 30, 2024

The link to:

https://docs.egi.eu/documentation/628/providers/cloud-compute/openstack/vo_config/

from:

https://docs.egi.eu/documentation/628/providers/cloud-compute/openstack/aai/#additional-vos

fails in the tests but works in the preview.

I think this happened in the past but cant' remember what the solution was.

I also suffered this in #623 and reorganised the docs, I think for this one, it's better to ignore this and get it fixed later

Copy link
Contributor

@enolfc enolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but just a very minor change request.

content/en/providers/cloud-compute/openstack/aai.md Outdated Show resolved Hide resolved
Co-authored-by: Enol Fernández <enol.fernandez@egi.eu>
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/628

Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/628

Copy link
Contributor

@enolfc enolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@enolfc
Copy link
Contributor

enolfc commented Jan 30, 2024

The link to:
https://docs.egi.eu/documentation/628/providers/cloud-compute/openstack/vo_config/
from:
https://docs.egi.eu/documentation/628/providers/cloud-compute/openstack/aai/#additional-vos
fails in the tests but works in the preview.
I think this happened in the past but cant' remember what the solution was.

I also suffered this in #623 and reorganised the docs, I think for this one, it's better to ignore this and get it fixed later

@gwarf do you think we can merge this failing?

@gwarf
Copy link
Member

gwarf commented Jan 30, 2024

The link to:
https://docs.egi.eu/documentation/628/providers/cloud-compute/openstack/vo_config/
from:
https://docs.egi.eu/documentation/628/providers/cloud-compute/openstack/aai/#additional-vos
fails in the tests but works in the preview.
I think this happened in the past but cant' remember what the solution was.

I also suffered this in #623 and reorganised the docs, I think for this one, it's better to ignore this and get it fixed later

@gwarf do you think we can merge this failing?

Yes, the same old error, we cannot do much apart reorganising this section, of patchign the link checker to get it work wiht this set up.
So fine with me to merge it.

@gwarf gwarf merged commit 443d0db into main Jan 30, 2024
15 of 16 checks passed
@gwarf gwarf deleted the vo-cleaning branch January 30, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe for preview Pull request vetted as safe for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants