Now denovo_phospho can contain missing mutations #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtiberti
requested changes
Apr 16, 2024
mavisp/modules.py
Outdated
Comment on lines
740
to
745
| if mutation in aggregated_df.columns: | ||
| restype_resnum_kinase = row['restype_resnum_kinase'] | ||
| if pd.isna(row['WT']) and not pd.isna(row[mutation]) and row['sas_sc_rel'] > 20: | ||
| gain_of_function[mutation].append(restype_resnum_kinase) | ||
| elif not pd.isna(row['WT']) and pd.isna(row[mutation]): | ||
| loss_of_function[mutation].append(restype_resnum_kinase) |
There was a problem hiding this comment.
does it make more sense to pre-filter mutations so that you don't have to cycle over the full list, even though you consistently skip some? e.g.
available_mutations = list(set(mutations).intersection(set(aggregated_df.columns))
...
for mutation in available_mutations:
...
mtiberti
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #243, now denovo_phoshop might contain missing mutations from mutlist, since we are not processing all of them anymore.