Bug fix #71
Merged
Bug fix #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
realalanc
commented
Jan 28, 2024
realalanc
commented
As for some Uniprot id, there is no suitable gene name, so when running line 163, it gets a 200 OK, but when running into line 165, it gets no key 'geneName', so raises KeyError The very first uniprot id identified is A0A1D6EIG7, I tried getting json by my browser and read the website of this id, the problem consists. As far as I know, many other genes correspond this situation.
It can be seen that, the 'geneName' key is in absence.
Similarly, we also need to check the existence of the key 'gene' in the same line 165. Also, in line 170, the name 'uniprot_id' is not defined, it may be 'uniprot_accession_number' instead?
As for some Uniprot id, there is no suitable gene name, so when running line 163, it gets a 200 OK, but when running into line 165, it gets no key 'geneName', so raises KeyError The very first uniprot id identified is A0A1D6EIG7, I tried getting json by my browser and read the website of this id, the problem consists. As far as I know, many other genes correspond this situation. Similarly, we also need to check the existence of the key 'gene' in the same line 165. Also, in line 170, the name 'uniprot_id' is not defined, it may be 'uniprot_accession_number' instead?
|
Thank you very much for identifying this challenge and the suggestion to solve it. |
DegnKristine
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.