Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implements highlighted features in the static site. #171

Merged
merged 22 commits into from
Nov 24, 2022

Conversation

white-gorilla
Copy link
Contributor

@white-gorilla white-gorilla commented Nov 7, 2022

This PR implements the 2 sections "How is it efficient?" and "Pretty crazy performance gains".
It integrates the two corresponding illustrations, one of which can be enlarged in a modal.

The integration is responsive and has been tested on:

  • Brave Chromium (latest)
  • Safari desktop (latest)
  • Firefox desktop (latest)
  • iOS Brave Chromium (latest)
  • iOS Safari desktop (latest)
  • iOS Firefox desktop (latest)

A test on your browsers and a feedback or a visual validation would be a plus.

@jonathlela If you can possibly take a look to be in the know.

fix #166

A video is in the issue #166.

Capture d’écran 2022-11-17 à 15 34 39

@white-gorilla white-gorilla marked this pull request as draft November 7, 2022 17:47
@white-gorilla white-gorilla self-assigned this Nov 7, 2022
@white-gorilla white-gorilla marked this pull request as ready for review November 17, 2022 14:08
Copy link
Contributor

@gaetansnl gaetansnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Animation looks great. I just think it looks better without shadows
image

And the thing I noticed is that the animation starts before we scroll to the bottom I think

@white-gorilla
Copy link
Contributor Author

white-gorilla commented Nov 24, 2022

@gaetansnl I changed the text in the efficiency SVG animation so that it doesn't talk about core.

Animation looks great. I just think it looks better without shadows

In the absolute you are right. But I prefer to reinforce these two blocks and distinguish them with a very light shadow, especially for the image that is clickable and has an enlargement icon (that opens a popin).

is that the animation starts before we scroll to the bottom It

I couldn't solve this with the exported animation. I had to run it indefinitely to recover this problem.

@white-gorilla white-gorilla merged commit eb46319 into main Nov 24, 2022
@white-gorilla white-gorilla deleted the feat/add-highlighted-features-in-static-site branch November 24, 2022 17:21
@white-gorilla white-gorilla restored the feat/add-highlighted-features-in-static-site branch November 29, 2022 10:25
@white-gorilla white-gorilla deleted the feat/add-highlighted-features-in-static-site branch November 29, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FRONT] Design and integrate performance and efficiency illustrations into the site.
2 participants