Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support stride for layernorm when dim is more than 3 #192

Merged
merged 1 commit into from
Nov 30, 2022
Merged

fix: support stride for layernorm when dim is more than 3 #192

merged 1 commit into from
Nov 30, 2022

Conversation

gaetansnl
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the fix hurrah, bug fixed! label Nov 29, 2022
@pommedeterresautee
Copy link
Member

test pass

pytest test/test_torchdynamo.py -k "(benchmark and optimized) or test_t5" -x     
=========================================================================================== 105 passed, 161 deselected in 2256.36s (0:37:36) ===========================================================================================

pommedeterresautee
pommedeterresautee approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@pommedeterresautee pommedeterresautee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaetansnl gaetansnl linked an issue Nov 30, 2022 that may be closed by this pull request
layernorm not working on non-contiguous tensors #193
Closed
@gaetansnl
Copy link
Contributor Author

full test layernorm/torchdynamo ok

@gaetansnl gaetansnl merged commit 24ca9e1 into main Nov 30, 2022
@gaetansnl gaetansnl deleted the fix/layernorm-stride-2 branch November 30, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pommedeterresautee pommedeterresautee pommedeterresautee approved these changes

Assignees

@gaetansnl gaetansnl

Labels
fix hurrah, bug fixed!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

layernorm not working on non-contiguous tensors
2 participants
@gaetansnl @pommedeterresautee