Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Landsat no-data issues #85

Merged
merged 6 commits into from
Oct 21, 2023

Conversation

lukasValentin
Copy link
Collaborator

The Landsat sensor class has been updated to address the bugs found in #84. To do so, the no-nodata checking in the Band class has been improved further. The Band.from_rasterio method will now raise a TypeError in case no no-data value is provided to ensure that there is always a no-data value.

@lukasValentin lukasValentin added this to the v0.2.3 milestone Oct 21, 2023
@lukasValentin lukasValentin self-assigned this Oct 21, 2023
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #85 (d4f2bac) into master (ddbf786) will increase coverage by 0.86%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   56.75%   57.61%   +0.86%     
==========================================
  Files          68       68              
  Lines        5286     5290       +4     
  Branches     1060     1060              
==========================================
+ Hits         3000     3048      +48     
+ Misses       1979     1940      -39     
+ Partials      307      302       -5     
Flag Coverage Δ
unittests 57.61% <78.57%> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
eodal/core/band.py 75.98% <100.00%> (+0.35%) ⬆️
eodal/core/sensors/landsat.py 70.20% <62.50%> (+16.67%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lukasValentin lukasValentin merged commit e1941b7 into EOA-team:master Oct 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant