Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore no-data values when scaling band data and allow band selection by color name for Sentinel-2 #87

Merged
merged 8 commits into from
Oct 27, 2023

Conversation

lukasValentin
Copy link
Collaborator

This PR addresses and closes #86. No-data values are considered, i.e. ignored, when scaling.

In addition, a small bug was fixed allowing now to select Sentinel-2 bands also by color names, as it is already supported for Landsat data:

color_names = ['blue', 'green', 'red']  # is the same as 
band_names =  ['B02', 'B03', 'B04']  # when calling Sentinel2.from_safe

@lukasValentin lukasValentin added the enhancement New feature or request label Oct 27, 2023
@lukasValentin lukasValentin added this to the v0.2.3 milestone Oct 27, 2023
@lukasValentin lukasValentin self-assigned this Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #87 (0e68be4) into master (e1941b7) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   57.61%   57.58%   -0.04%     
==========================================
  Files          68       68              
  Lines        5290     5300      +10     
  Branches     1060     1063       +3     
==========================================
+ Hits         3048     3052       +4     
- Misses       1940     1943       +3     
- Partials      302      305       +3     
Flag Coverage Δ
unittests 57.58% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
eodal/core/band.py 75.53% <100.00%> (-0.45%) ⬇️
eodal/core/raster.py 73.16% <ø> (ø)
eodal/core/sensors/landsat.py 70.32% <100.00%> (+0.12%) ⬆️
eodal/core/sensors/sentinel2.py 62.15% <100.00%> (+0.42%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lukasValentin lukasValentin merged commit 3796df3 into EOA-team:master Oct 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: ignore nodata values by default when scaling data (or any other transformation)
1 participant