Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Process Generated Transactions #174

Closed
wanderingbort opened this issue Aug 15, 2017 · 1 comment · Fixed by #227
Closed

Process Generated Transactions #174

wanderingbort opened this issue Aug 15, 2017 · 1 comment · Fixed by #227
Assignees
@wanderingbort
Labels
enhancement
Milestone
EOS Dawn 1.0

Comments

@wanderingbort
Copy link
Contributor

GeneratedTransaction s can be scheduled but they cannot be processed at the moment.

This task will refactor processing of SignedTransaction s that is currently part of chain_controller to allow for processing GenerateTransaction s as well with as much shared code as possible.

NB: this task will not provide API or WASM-VM support for generating transactions. That will come in another issue.
@wanderingbort wanderingbort added this to the Test Network Release milestone Aug 15, 2017
@wanderingbort wanderingbort self-assigned this Aug 15, 2017
@wanderingbort wanderingbort mentioned this issue Aug 15, 2017
Closed
@wanderingbort wanderingbort mentioned this issue Aug 25, 2017
Closed
@wanderingbort
Copy link
Contributor Author

Most of this is done. There are a few things left to do for #224 (like test cases).

This has exposed some cracks in our current transaction type hierarchy: Inheriting the generated "data" type from a type that provides functionality turns in to a messy diamond multiple inheritance when some of the functionality belong in the shared base class. This was discussed in the dev chat and resolved by extracting methods that only require the data from the shared base Transaction type into functions which take the least permissive Transaction& needed as an input.

This has also exposed the inappropriate use of ProcessedTransaction which is derived from SignedTransaction for synchronous transaction outputs. Unlike GeneratedTransactions these do not need an explicit ID and they are immediately processed so, they carry output. As a result we now have 3 variations of "output" transactions:

  • implicit id, with signatures, with output: ProcessedTransaction
  • explicit id to be applied in the future: GeneratedTransaction
  • implicit/no id with output: ProcessedSyncTransaction

After this issue is done, we may want to revisit the type system here from the generated types on through to make sure they are still consistent with the ideals of the system and that all the moving parts have value in the current set of working assumptions.

wanderingbort added a commit to wanderingbort/eos that referenced this issue Aug 25, 2017
@wanderingbort
allow validation of GeneratedTransactions and unify as much code as p…
d432b6c 
…ossible. ref EOSIO#174
wanderingbort added a commit to wanderingbort/eos that referenced this issue Aug 25, 2017
@wanderingbort
add processing of GeneratedTransaction sharing code where possible. ref
d54bc83 
EOSIO#174
wanderingbort added a commit to wanderingbort/eos that referenced this issue Aug 25, 2017
@wanderingbort
check derived output against the outputs encoded in a block. fixes EO…
96ebf95 
…SIO#224 ref EOSIO#174
@wanderingbort wanderingbort mentioned this issue Aug 25, 2017
Merged
wanderingbort added a commit to wanderingbort/eos that referenced this issue Aug 25, 2017
@wanderingbort
fix botched pre-push merge. ref EOSIO#174
6f214e1
ljrprocc pushed a commit to bithacks-tech/myeosio that referenced this issue Jul 4, 2018
Merge pull request EOSIO#174 from enumivo/staging
4772ee5 
Staging
NorseGaud pushed a commit that referenced this issue Jul 30, 2019
# This is a combination of 186 commits.
6c09577 
# This is the 1st commit message:

various improvements

# This is the commit message #2:

new hash

# This is the commit message #3:

fix for script path

# This is the commit message #4:

fixes

# This is the commit message #5:

fixes

# This is the commit message #6:

fixes

# This is the commit message #7:

fixes

# This is the commit message #8:

fixes

# This is the commit message #9:

fixes

# This is the commit message #10:

fixes

# This is the commit message #11:

fixes

# This is the commit message #12:

fixes

# This is the commit message #13:

fixes

# This is the commit message #14:

fixes

# This is the commit message #15:

fixes

# This is the commit message #16:

fixes

# This is the commit message #17:

fixes

# This is the commit message #18:

fixes

# This is the commit message #19:

fixes

# This is the commit message #20:

fixes

# This is the commit message #21:

fixes

# This is the commit message #22:

fixes

# This is the commit message #23:

fixes

# This is the commit message #24:

fixes

# This is the commit message #25:

fixes

# This is the commit message #26:

testing

# This is the commit message #27:

testing

# This is the commit message #28:

testing

# This is the commit message #29:

testing

# This is the commit message #30:

testing

# This is the commit message #31:

testing

# This is the commit message #32:

testing

# This is the commit message #33:

testing

# This is the commit message #34:

testing

# This is the commit message #35:

testing

# This is the commit message #36:

testing

# This is the commit message #37:

testing

# This is the commit message #38:

testing

# This is the commit message #39:

testing

# This is the commit message #40:

testing

# This is the commit message #41:

testing

# This is the commit message #42:

testing

# This is the commit message #43:

testing

# This is the commit message #44:

fixes

# This is the commit message #45:

fixes

# This is the commit message #46:

fixes

# This is the commit message #47:

fixes

# This is the commit message #48:

fixes

# This is the commit message #49:

fixes

# This is the commit message #50:

fixes

# This is the commit message #51:

fixes

# This is the commit message #52:

fixes

# This is the commit message #53:

fixes

# This is the commit message #54:

fixes

# This is the commit message #55:

fixes

# This is the commit message #56:

fixes

# This is the commit message #57:

fixes

# This is the commit message #58:

fixes

# This is the commit message #59:

fixes

# This is the commit message #60:

fixes

# This is the commit message #61:

fixes

# This is the commit message #62:

fixes

# This is the commit message #63:

fixes

# This is the commit message #64:

fixes

# This is the commit message #65:

fixes

# This is the commit message #66:

fixes

# This is the commit message #67:

fixes

# This is the commit message #68:

fixes

# This is the commit message #69:

fixes

# This is the commit message #70:

fixes

# This is the commit message #71:

fixes

# This is the commit message #72:

fixes

# This is the commit message #73:

fixes

# This is the commit message #74:

fixes

# This is the commit message #75:

fixes

# This is the commit message #76:

fixes

# This is the commit message #77:

fixes

# This is the commit message #78:

fixes

# This is the commit message #79:

more testing

# This is the commit message #80:

testing

# This is the commit message #81:

fixes

# This is the commit message #82:

fixes

# This is the commit message #83:

fixes

# This is the commit message #84:

fixes

# This is the commit message #85:

fixes

# This is the commit message #86:

fixes

# This is the commit message #87:

fixes

# This is the commit message #88:

fixes

# This is the commit message #89:

fixes

# This is the commit message #90:

fixes

# This is the commit message #91:

fixes

# This is the commit message #92:

fixes

# This is the commit message #93:

propagate-environment for buildkite-agent

# This is the commit message #94:

propagate-environment for buildkite-agent

# This is the commit message #95:

propagate-environment for buildkite-agent

# This is the commit message #96:

propagate-environment for buildkite-agent

# This is the commit message #97:

fixes

# This is the commit message #98:

fixes

# This is the commit message #99:

fixes

# This is the commit message #100:

fixes

# This is the commit message #101:

fixes

# This is the commit message #102:

fixes

# This is the commit message #103:

fixes

# This is the commit message #104:

fixes

# This is the commit message #105:

fixes

# This is the commit message #106:

fixes

# This is the commit message #107:

fixes

# This is the commit message #108:

fixes

# This is the commit message #109:

fixes

# This is the commit message #110:

fixes

# This is the commit message #111:

fixes

# This is the commit message #112:

fixes

# This is the commit message #113:

fixes

# This is the commit message #114:

fixes

# This is the commit message #115:

fixes

# This is the commit message #116:

fixes

# This is the commit message #117:

fixes

# This is the commit message #118:

fixes

# This is the commit message #119:

fixes

# This is the commit message #120:

fixes

# This is the commit message #121:

fixes

# This is the commit message #122:

fixes

# This is the commit message #123:

fixes

# This is the commit message #124:

fixes

# This is the commit message #125:

fixes

# This is the commit message #126:

fixes

# This is the commit message #127:

fixes

# This is the commit message #128:

fixes

# This is the commit message #129:

fixes

# This is the commit message #130:

fixes

# This is the commit message #131:

fixes

# This is the commit message #132:

fixes

# This is the commit message #133:

fixes

# This is the commit message #134:

fixes

# This is the commit message #135:

fixes

# This is the commit message #136:

fixes

# This is the commit message #137:

fixes

# This is the commit message #138:

fixes

# This is the commit message #139:

fixes

# This is the commit message #140:

fixes

# This is the commit message #141:

fixes

# This is the commit message #142:

fixes

# This is the commit message #143:

fixes

# This is the commit message #144:

fixes

# This is the commit message #145:

fixes

# This is the commit message #146:

fixes

# This is the commit message #147:

fixes

# This is the commit message #148:

fixes

# This is the commit message #149:

fixes

# This is the commit message #150:

fixes

# This is the commit message #151:

fixes

# This is the commit message #152:

fixes

# This is the commit message #153:

testing

# This is the commit message #154:

fixes

# This is the commit message #155:

fixes

# This is the commit message #156:

fixes

# This is the commit message #157:

fixes

# This is the commit message #158:

fixes

# This is the commit message #159:

fixes

# This is the commit message #160:

fixes

# This is the commit message #161:

fixes

# This is the commit message #162:

fixes

# This is the commit message #163:

fixes

# This is the commit message #164:

fixes

# This is the commit message #165:

fixes

# This is the commit message #166:

fixes

# This is the commit message #167:

fixes

# This is the commit message #168:

fixes

# This is the commit message #169:

fixes

# This is the commit message #170:

fixes

# This is the commit message #171:

fixes

# This is the commit message #172:

fixes

# This is the commit message #173:

fixes

# This is the commit message #174:

fixes

# This is the commit message #175:

fixes

# This is the commit message #176:

fixes

# This is the commit message #177:

fixes

# This is the commit message #178:

fixes

# This is the commit message #179:

fixes

# This is the commit message #180:

fixes

# This is the commit message #181:

fixes

# This is the commit message #182:

fixes

# This is the commit message #183:

fixes

# This is the commit message #184:

fixes

# This is the commit message #185:

fixes

# This is the commit message #186:

fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wanderingbort wanderingbort

Labels
enhancement
Projects
None yet
Milestone
EOS Dawn 1.0
Development

Successfully merging a pull request may close this issue.

process generated transactions wanderingbort/eos
1 participant
@wanderingbort