Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix for issue 173, --skip-transaction-signatures to eosd #177

Merged
merged 4 commits into from
Aug 18, 2017
Merged

Fix for issue 173, --skip-transaction-signatures to eosd #177

merged 4 commits into from
Aug 18, 2017

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Aug 15, 2017

No description provided.

bytemaster
bytemaster reviewed Aug 16, 2017
View reviewed changes
contracts/eoslib/eosc.dox Outdated
@@ -6,7 +6,12 @@
@section intro Introduction to EOSC

`eosc` is a command line tool that interfaces with the REST api exposed by @ref eosd. In order to use `eosc` you will need to
have a local copy of `eosd` running and configured to load the 'eos::chain_api_plugin'.
have a local copy of `eosd` running and configured to load the 'eos::chain_api_plugin'. Currently, `eosc` does not
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation misrepresents what is going on. It has nothing to do with eosc support for signature checking and everything to do with making it easy for developers to test functions without keys.

bytemaster
bytemaster reviewed Aug 16, 2017
View reviewed changes
plugins/chain_plugin/chain_plugin.cpp Outdated
"\n"
"***************************************\n"
"* *\n"
"* -- CHAIN IGNORING SIGNATURES -- *\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHAIN isn't ignoring it, this EOSD is ignoring it.

bytemaster
bytemaster reviewed Aug 16, 2017
View reviewed changes
plugins/chain_plugin/chain_plugin.cpp Outdated
@@ -166,7 +187,10 @@ bool chain_plugin::accept_block(const chain::signed_block& block, bool currently
}

void chain_plugin::accept_transaction(const chain::SignedTransaction& trx) {
chain().push_transaction(trx);
if (my->skip_flags & chain_controller::skip_transaction_signatures) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be overly verbose for flood testing.

bytemaster
bytemaster reviewed Aug 16, 2017
View reviewed changes
plugins/chain_plugin/chain_plugin.cpp Outdated
@@ -301,7 +329,10 @@ read_write::push_block_results read_write::push_block(const read_write::push_blo
}

read_write::push_transaction_results read_write::push_transaction(const read_write::push_transaction_params& params) {
auto ptrx = db.push_transaction(params);
if (skip_flags & chain_controller::skip_transaction_signatures) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than duplicating the bitwise logic, this should call chain_plugin::skip_transaction_signatures.

bytemaster
bytemaster reviewed Aug 16, 2017
View reviewed changes
plugins/chain_plugin/chain_plugin.cpp Outdated
@@ -177,6 +201,10 @@ bool chain_plugin::block_is_on_preferred_chain(const chain::block_id_type& block
return chain().get_block_id_for_num(chain::block_header::num_from_id(block_id)) == block_id;
}

bool chain_plugin::skip_transaction_signatures() const {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function name looks like an "action", eg start skipping transaction signatures, rather than the answer to a question, "is_skipping_trx_sigs" or "should_skip_sigs".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_skip_transaction_signatures() since all it does is check the flag?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_skipping_transaction_signatures()

bytemaster
bytemaster suggested changes Aug 16, 2017
View reviewed changes
Copy link
Contributor

@bytemaster bytemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a series of comments on this commit, please review the comments and make the relatively trivial changes.

@pmesnier
Copy link
Contributor

What about adding a compiled-in "test" mode that could allow commands to set the various skip- flags to be issued through the eosc? These commands would propagate as transactions through all networked nodes. Networked nodes would check for this capacity in peers upon startup and would only connect to similarly build nodes.

This way we could allow for such things as running tests across many nodes using varied levels of validation but without worrying about stopping and restarting all the connected nodes.

@heifner
Copy link
Contributor Author

heifner commented Aug 17, 2017

Ultimately you want all verifications in place I would think. For example, once the command line wallet is up and running it can be used in the p2p tests to provide the signatures. That way you are testing signature verification and performance along with everything else.

@bytemaster bytemaster merged commit 8ff41f2 into master Aug 18, 2017
@heifner heifner mentioned this pull request Aug 18, 2017
Closed
@heifner heifner deleted the skip-sig-173 branch August 18, 2017 12:55
ljrprocc pushed a commit to bithacks-tech/myeosio that referenced this pull request Jul 4, 2018
Merge pull request EOSIO#177 from enumivo/staging
c7f037a 
Staging
NorseGaud pushed a commit that referenced this pull request Jul 30, 2019
# This is a combination of 186 commits.
6c09577 
# This is the 1st commit message:

various improvements

# This is the commit message #2:

new hash

# This is the commit message #3:

fix for script path

# This is the commit message #4:

fixes

# This is the commit message #5:

fixes

# This is the commit message #6:

fixes

# This is the commit message #7:

fixes

# This is the commit message #8:

fixes

# This is the commit message #9:

fixes

# This is the commit message #10:

fixes

# This is the commit message #11:

fixes

# This is the commit message #12:

fixes

# This is the commit message #13:

fixes

# This is the commit message #14:

fixes

# This is the commit message #15:

fixes

# This is the commit message #16:

fixes

# This is the commit message #17:

fixes

# This is the commit message #18:

fixes

# This is the commit message #19:

fixes

# This is the commit message #20:

fixes

# This is the commit message #21:

fixes

# This is the commit message #22:

fixes

# This is the commit message #23:

fixes

# This is the commit message #24:

fixes

# This is the commit message #25:

fixes

# This is the commit message #26:

testing

# This is the commit message #27:

testing

# This is the commit message #28:

testing

# This is the commit message #29:

testing

# This is the commit message #30:

testing

# This is the commit message #31:

testing

# This is the commit message #32:

testing

# This is the commit message #33:

testing

# This is the commit message #34:

testing

# This is the commit message #35:

testing

# This is the commit message #36:

testing

# This is the commit message #37:

testing

# This is the commit message #38:

testing

# This is the commit message #39:

testing

# This is the commit message #40:

testing

# This is the commit message #41:

testing

# This is the commit message #42:

testing

# This is the commit message #43:

testing

# This is the commit message #44:

fixes

# This is the commit message #45:

fixes

# This is the commit message #46:

fixes

# This is the commit message #47:

fixes

# This is the commit message #48:

fixes

# This is the commit message #49:

fixes

# This is the commit message #50:

fixes

# This is the commit message #51:

fixes

# This is the commit message #52:

fixes

# This is the commit message #53:

fixes

# This is the commit message #54:

fixes

# This is the commit message #55:

fixes

# This is the commit message #56:

fixes

# This is the commit message #57:

fixes

# This is the commit message #58:

fixes

# This is the commit message #59:

fixes

# This is the commit message #60:

fixes

# This is the commit message #61:

fixes

# This is the commit message #62:

fixes

# This is the commit message #63:

fixes

# This is the commit message #64:

fixes

# This is the commit message #65:

fixes

# This is the commit message #66:

fixes

# This is the commit message #67:

fixes

# This is the commit message #68:

fixes

# This is the commit message #69:

fixes

# This is the commit message #70:

fixes

# This is the commit message #71:

fixes

# This is the commit message #72:

fixes

# This is the commit message #73:

fixes

# This is the commit message #74:

fixes

# This is the commit message #75:

fixes

# This is the commit message #76:

fixes

# This is the commit message #77:

fixes

# This is the commit message #78:

fixes

# This is the commit message #79:

more testing

# This is the commit message #80:

testing

# This is the commit message #81:

fixes

# This is the commit message #82:

fixes

# This is the commit message #83:

fixes

# This is the commit message #84:

fixes

# This is the commit message #85:

fixes

# This is the commit message #86:

fixes

# This is the commit message #87:

fixes

# This is the commit message #88:

fixes

# This is the commit message #89:

fixes

# This is the commit message #90:

fixes

# This is the commit message #91:

fixes

# This is the commit message #92:

fixes

# This is the commit message #93:

propagate-environment for buildkite-agent

# This is the commit message #94:

propagate-environment for buildkite-agent

# This is the commit message #95:

propagate-environment for buildkite-agent

# This is the commit message #96:

propagate-environment for buildkite-agent

# This is the commit message #97:

fixes

# This is the commit message #98:

fixes

# This is the commit message #99:

fixes

# This is the commit message #100:

fixes

# This is the commit message #101:

fixes

# This is the commit message #102:

fixes

# This is the commit message #103:

fixes

# This is the commit message #104:

fixes

# This is the commit message #105:

fixes

# This is the commit message #106:

fixes

# This is the commit message #107:

fixes

# This is the commit message #108:

fixes

# This is the commit message #109:

fixes

# This is the commit message #110:

fixes

# This is the commit message #111:

fixes

# This is the commit message #112:

fixes

# This is the commit message #113:

fixes

# This is the commit message #114:

fixes

# This is the commit message #115:

fixes

# This is the commit message #116:

fixes

# This is the commit message #117:

fixes

# This is the commit message #118:

fixes

# This is the commit message #119:

fixes

# This is the commit message #120:

fixes

# This is the commit message #121:

fixes

# This is the commit message #122:

fixes

# This is the commit message #123:

fixes

# This is the commit message #124:

fixes

# This is the commit message #125:

fixes

# This is the commit message #126:

fixes

# This is the commit message #127:

fixes

# This is the commit message #128:

fixes

# This is the commit message #129:

fixes

# This is the commit message #130:

fixes

# This is the commit message #131:

fixes

# This is the commit message #132:

fixes

# This is the commit message #133:

fixes

# This is the commit message #134:

fixes

# This is the commit message #135:

fixes

# This is the commit message #136:

fixes

# This is the commit message #137:

fixes

# This is the commit message #138:

fixes

# This is the commit message #139:

fixes

# This is the commit message #140:

fixes

# This is the commit message #141:

fixes

# This is the commit message #142:

fixes

# This is the commit message #143:

fixes

# This is the commit message #144:

fixes

# This is the commit message #145:

fixes

# This is the commit message #146:

fixes

# This is the commit message #147:

fixes

# This is the commit message #148:

fixes

# This is the commit message #149:

fixes

# This is the commit message #150:

fixes

# This is the commit message #151:

fixes

# This is the commit message #152:

fixes

# This is the commit message #153:

testing

# This is the commit message #154:

fixes

# This is the commit message #155:

fixes

# This is the commit message #156:

fixes

# This is the commit message #157:

fixes

# This is the commit message #158:

fixes

# This is the commit message #159:

fixes

# This is the commit message #160:

fixes

# This is the commit message #161:

fixes

# This is the commit message #162:

fixes

# This is the commit message #163:

fixes

# This is the commit message #164:

fixes

# This is the commit message #165:

fixes

# This is the commit message #166:

fixes

# This is the commit message #167:

fixes

# This is the commit message #168:

fixes

# This is the commit message #169:

fixes

# This is the commit message #170:

fixes

# This is the commit message #171:

fixes

# This is the commit message #172:

fixes

# This is the commit message #173:

fixes

# This is the commit message #174:

fixes

# This is the commit message #175:

fixes

# This is the commit message #176:

fixes

# This is the commit message #177:

fixes

# This is the commit message #178:

fixes

# This is the commit message #179:

fixes

# This is the commit message #180:

fixes

# This is the commit message #181:

fixes

# This is the commit message #182:

fixes

# This is the commit message #183:

fixes

# This is the commit message #184:

fixes

# This is the commit message #185:

fixes

# This is the commit message #186:

fixes
Frank-AFN added a commit to eosiosg/eos that referenced this pull request Jun 25, 2020
@Frank-AFN
Fix: issue EOSIO#177
b9ff409
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nathanielhourt nathanielhourt nathanielhourt left review comments

@bytemaster bytemaster bytemaster requested changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heifner @pmesnier @nathanielhourt @bytemaster