Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix nested container tests #11006

Merged
merged 6 commits into from
Jan 6, 2022
Merged

Conversation

shahabi8
Copy link
Contributor

@shahabi8 shahabi8 commented Jan 4, 2022

Change Description

This PR fixes nested container tests for pair and map containers.
Map can be defined through key and value like this: [{"key":10, "value":100],{"key":10, "value":100}]
Pair can be defined through first and second like this: ["first":30, "second":{"first":301, "second":302}]

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

Copy link

@plroblox plroblox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent ! map should go with key-value whereas pair should go-with firt-second regarding the JSON input formats of typess involving map/pair

@shahabi8 shahabi8 merged commit 157df8a into develop Jan 6, 2022
@shahabi8 shahabi8 deleted the fsh-epe-1870-nested-container-develop branch January 6, 2022 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants