This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Adding memo to transfer type #248 #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bytemaster
commented
Aug 29, 2017
bytemaster
commented
- also adding readscope to Transaction header Transfer example .. Unit test typo? #70
- also adding readscope to Transaction header #70
|
I'm working on fixing the build, will push in a moment. |
- added checks on redundant scope specification in readscope #70
heifner
reviewed
Aug 29, 2017
| @@ -71,6 +72,7 @@ struct transfer | |||
| from AccountName # may not be the message.sender if message.sender has delegated authority by from | |||
| to AccountName | |||
| amount UInt64 | |||
| memo String | |||
There was a problem hiding this comment.
Seems like we should limit the size of the string. Currently, this is a std::string.
heifner
added a commit
that referenced
this pull request
Aug 29, 2017
This reverts commit 4fcf10316c754e28de4907e6a2a60ecfbdf94ef4.
taokayan
pushed a commit
to taokayan/eos
that referenced
this pull request
May 15, 2019
Force execute compile time
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.