Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help messaging and transaction options to reduce duplicate transaction errors #422

Merged

Conversation

@wanderingbort
Copy link
Contributor

commented Sep 13, 2017

closes #384

  • more informative error messages
    • client side system for translating non-human-friendly error spew
    • optional -v,--verbose option to get back the error spew of olde
  • standard transaction options composable on any sub-command
    • expiration support -x,--expiration[=]<milliseconds til expiration>
    • force unique transaction support -f,--force-unique
      • uses the transfer memo when it can
      • uses a superfluous message to eos with type nonce otherwise
      • do we want to just pad out the last messages payload bytes instead?
  • BONUS: human readable error messaging for:
    • permissions you dont have the keys for
    • referring to accounts that don't exist
    • using push message for an unknown ABI
    • opening an unknown wallet
    • incorrect password when unlocking wallet
    • trying to access a locked wallet

@wanderingbort wanderingbort added this to the EOS Dawn 1.0 milestone Sep 13, 2017

@wanderingbort wanderingbort requested a review from bytemaster Sep 13, 2017

@wanderingbort

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2017

examples of the new error messaging:

$ ./eosc transfer inita user1 100 "The Memo"
An error occurred while submitting the transaction for this command!

The transaction references an account which does not exist.
Unknown accounts:
  - user1

Please check the account names and try again!   

$ ./eosc wallet open -n foo
Unable to find a wallet named "foo", are you sure you typed the name correctly?

$ ./eosc wallet unlock
password: <obviously bad password>
Invalid password for wallet named "default"

$ ./eosc transfer inita user1 100 "The Memo"
An error occurred while submitting the transaction for this command!

The transaction requires permissions that could not be authorized by the wallet.
Missing authrizations:
  - inita@active

Please make sure the proper keys are imported into an unlocked wallet and try again!    

@bytemaster

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2017

This looks amazing, your bonus efforts also look good except it may invalidate one of the steps in my tutorial! Need to check to see if I can use push message with hex data or if your new checks cause that to fail.

@bytemaster bytemaster merged commit a03b66b into EOSIO:master Sep 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.