"eosio_uninstall.sh --full" to delete directories with configs #5383
Conversation
eosio_build.sh
Outdated
| if [ "$(id -u)" -ne 0 ]; then | ||
| printf "\n\tThis requires sudo. Please run with sudo.\n\n" | ||
| exit -1 | ||
| fi |
There was a problem hiding this comment.
eosio_build.sh should not require sudo
|
Curious why you didn't edit and remove the sudo requirement, @heifner? |
|
@NorseGaud it was a bit of a fly-by review. Just not a high priority at the moment. Thanks for the contribution. |
|
@heifner Appreciate the follow-up. Just curious if there is a process I should be following to contribute. Want to follow the guidelines if they exist and make your life easier. Thanks |
|
Actually, PRs should be against |
|
As for docs. Pick a close page and suggest edits there. |
eosio_uninstall.sh
Outdated
| if [ "$1" == "--full" ]; then | ||
| if [ -d ~/Library/Application\ Support/eosio ]; then rm -rf ~/Library/Application\ Support/eosio; fi # Mac OS | ||
| if [ -d ~/.local/share/eosio ]; then rm -rf ~/.local/share/eosio; fi # Linux | ||
| if [ -d /usr/local/eosio ]; then rm -rf /usr/local/eosio; fi |
There was a problem hiding this comment.
Line 33 is redundant, line 24 already deletes /usr/local/eosio outside of the full switch. I like having the other directories guarded off with the full flag, because you might not want to destroy your user/application generated files.
There was a problem hiding this comment.
@heifner, @jgiszczak I can't think of any generated (not at install time) files that are placed in /usr/local/eosio, also should we include the keosd generated folders and the opt folders for the boost we install on Linux? This was originally intended to aid in migrating between versions, but with the inclusion of the nodeos directories, it makes me question how clean of an uninstall do we want to go, as in full revert (brew uninstalls that sort of thing).
There was a problem hiding this comment.
You're right, good catch. Thanks!
|
All set I think. Any updates for this? |
Adding code to support --full for eosio_uninstall.sh to remove directories with configs.
Thank you