stop creating anonymous volumes during image build

[tmclane]

Best practices dictate that you do not define VOLUMEs in the DockerFile.

Instead the volume should be defined in the docker-compose.yml file such that you can name them so they are not 'lost' and can be identified later and managed.
Creating them during the build means they are only used during the image creation process and then are never utilized again. This is a wasted effort plus a waste of disk space.

[ericiles]

Hi @tmclane,

Thanks for the PR! These changes break the Docker/nodeosd.sh script, as it was written with the expectation that the /opt/eosio/bin/data-dir directory exists. A simple solution is to add the following directly below the cd command at the top of Docker/nodeosd.sh:

if [ ! -d "/opt/eosio/bin/data-dir" ]; then
    mkdir /opt/eosio/bin/data-dir
fi

If you can update your PR with this change, I can then approve this PR and get it merged in.

[tmclane]

@ericiles done. I didn't run into that problem because in my docker-compose.yml file I had mounted a volume at that location so it existed.